Fix wrong default initialization value for ctrl 8 (Balance)

Fix #35
pedrolcl · Dec 28, 2024 · 37a4c2a · 37a4c2a
1 parent beda54d
commit 37a4c2a
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 7 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -19,7 +19,7 @@ with this program; If not, see <http://www.gnu.org/licenses/>.
 cmake_minimum_required(VERSION 3.16)
 
 project( VMPK
-    VERSION 0.9.1
+    VERSION 0.9.2
     LANGUAGES CXX
     DESCRIPTION "Virtual MIDI Piano Keyboard"
     HOMEPAGE_URL "https://vmpk.sourceforge.io/"

diff --git a/src/constants.h b/src/constants.h
@@ -132,7 +132,7 @@ const char MIDICTLDEFVALUE[] = "MIDICTLDEFVAL\0";
 const int MIDIGMDRUMSCHANNEL = 9;
 const int MIDICHANNELS = 16;
 const int MIDIVELOCITY = 100;
-const int MIDIPAN = 64;
+const int MIDIMIDVALUE = 64;
 const int MIDIVOLUME = 100;
 const int MIDIMAXVALUE = 127;
 const int DEFAULTBASEOCTAVE = 3;

diff --git a/src/mididefs.h b/src/mididefs.h
@@ -44,9 +44,10 @@
 #define CALC_LSB(x) (x % 0x80)
 #define CALC_MSB(x) (x / 0x80)
 
-#define CTL_VOLUME           7
-#define CTL_PAN             10
-#define CTL_EXPRESSION      11
-#define CTL_REVERB_SEND     91
+#define CTL_VOLUME 7
+#define CTL_BALANCE 8
+#define CTL_PAN 10
+#define CTL_EXPRESSION 11
+#define CTL_REVERB_SEND 91
 
 #endif /* MIDIDEFS_H */
diff --git a/src/vpiano.cpp b/src/vpiano.cpp
@@ -1272,8 +1272,11 @@ void VPiano::initControllers(int channel)
             case CTL_VOLUME:
                 m_ctlState[channel][CTL_VOLUME] = MIDIVOLUME;
                 break;
+            case CTL_BALANCE:
+                m_ctlState[channel][CTL_BALANCE] = MIDIMIDVALUE;
+                break;
             case CTL_PAN:
-                m_ctlState[channel][CTL_PAN] = MIDIPAN;
+                m_ctlState[channel][CTL_PAN] = MIDIMIDVALUE;
                 break;
             case CTL_EXPRESSION:
                 m_ctlState[channel][CTL_EXPRESSION] = MIDIMAXVALUE;