Skip to content

Commit

Permalink
Disable uploading coverage on Windows
Browse files Browse the repository at this point in the history
The handrolled coveralls upload cannot handle mixed operating systems.

Refs Gallopsled#2480
  • Loading branch information
peace-maker committed Dec 18, 2024
1 parent 3f22d81 commit 5ad4723
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -296,17 +296,17 @@ jobs:
run: |
python -bb -m coverage run -m sphinx -b doctest docs/source docs/build/doctest
- uses: actions/upload-artifact@v4
with:
name: coverage-windows
path: .coverage*
include-hidden-files: true
# FIXME: Paths are broken when uploading coverage on ubuntu
# coverage.exceptions.NoSource: No source for code: '/home/runner/work/pwntools/pwntools/D:\a\pwntools\pwntools\pwn\__init__.py'.
# - uses: actions/upload-artifact@v4
# with:
# name: coverage-windows
# path: .coverage*
# include-hidden-files: true

upload-coverage:
runs-on: ubuntu-latest
needs:
- test
- windows-test
needs: test
steps:
- uses: actions/checkout@v4
with:
Expand Down

0 comments on commit 5ad4723

Please sign in to comment.