BUG: Begin timeout

[ZLLentz]

Description

This PR fixes a race condition in Daq.begin that would cause failed starts when the external scripts we call get slow. There was an assumption that the timeout for begin would only account for pydaq time, but this is not the case.

Now we have separate timeouts for begin and for the external scripts.

Motivation and Context

#65

How Has This Been Tested?

Locally with the real DAQ, hopefully the tests still pass

Where Has This Been Documented?

This will be in the notes for the next release.

[ZLLentz]

I have requested reviews from everyone who was in the slack chat, but do not feel obligated to review. I just want to bring awareness to what happened here for the curious.

[ZryletTC]

I don't have a full grasp of what's going on here so I'd prefer if someone else also reviewed but the logic looks sound.

I can't comment there since it's not part of your commits but should lines 450 and 453 of daq.py be changed to set_finished and set_exception?

[codecov-commenter]

Codecov Report

Merging #66 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #66   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          770       779    +9     
=========================================
+ Hits           770       779    +9     

Impacted Files	Coverage Δ
pcdsdaq/daq.py	100.00% <100.00%> (ø)
pcdsdaq/ext_scripts.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8351255...1c10a11. Read the comment docs.