FIX: update pre-commit image to current ubuntu latest #152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ubuntu-20.04 image runs python 3.8 which is too old for some of the twincat pre-commit builds.
Rather than keep using the old image, I opted to update to the 22.04 image that is currently tagged as "ubuntu-latest".
I could have also chosen 24.04 but since it wasn't tagged as latest I decided to only go up to 22.04.
List of builds:
https://github.com/actions/runner-images/tree/main
I then tried to run pre-commit on CI on a repo that was previously failing.
Failing build: https://github.com/pcdshub/lcls-twincat-math/actions/runs/11582459856/job/32245532359
My passing build: https://github.com/ZLLentz/lcls-twincat-math/actions/runs/11710367753/job/32616497674
I did not try this again on the python repos but I expect this to be transparent.
I am not currently interested in updating all the builds because that has some (low) risk of creating havoc and I'm not ready for that today.
Ref https://jira.slac.stanford.edu/browse/ECS-6684