DEV: Tested DA valve. Removed Roughing panel and now reading the data… #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from beamline vac plc
jyotiphy
reviewed
May 3, 2024
| if( qRIXS_PRO_01.stPump.eState = pumpSTARTING ) OR ( qRIXS_PRO_01.stPump.eState = pumpRUNNING ) | ||
| THEN QRIX_ROUGH_VRO_01.M_Open(TRUE); | ||
| END_IF | ||
| QRIX_ROUGH_VRO_01(i_xExtILK_OK:= (qRIXS_PRO_01.stPump.eState = pumpRUNNING OR qRIXS_PRO_01.stPump.eState = pumpSTARTING ), i_xOverrideMode:= , iq_stValve=> ); | ||
| ]]></ST> | ||
| QRIX_ROUGH_VRO_01(i_xExtILK_OK:= (qRIXS_PRO_01.st_pro.eState = pumpRUNNING OR qRIXS_PRO_01.st_pro.eState = pumpSTARTING ), i_xOverrideMode:= , iq_stValve=> ); |
There was a problem hiding this comment.
should here be .st_pro or .stPump ? If you see up on line 29, you have stPump ?
There was a problem hiding this comment.
you can actually remove VRO from qRIXS now
There was a problem hiding this comment.
It is commented out. The line before there is (* and the last line is *). I will delete it anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… from beamline vac plc
Description
Motivation and Context
How Has This Been Tested?
Where Has This Been Documented?
Screenshots (if appropriate):
Pre-merge checklist
Always Newestpre-commit(alternativelypre-commit run --all-files)