Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TM1K2 PLC limits and IM4K2 ppm 24-bit readout fix #67

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

jyotiphy
Copy link
Contributor

@jyotiphy jyotiphy commented Jul 2, 2024

Description

  • Disable PLC limits for TM1K2 for now until we have all targets setup with their setpoints/delta
  • Fix fTermMin for IM4K2 ppm 24-bit readout

Motivation and Context

Attempt to fix scaling for 24-bit ppm readout

How Has This Been Tested?

Haven't yet tested

Screenshots (if appropriate):

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • Libraries are set to fixed versions and not Always Newest
  • [ x] Code committed with pre-commit (alternatively pre-commit run --all-files)

@ZLLentz
Copy link
Member

ZLLentz commented Jul 2, 2024

Reference link to the underlying bug that requires us to handle the analog input this way: pcdshub/lcls-twincat-general#54

@jyotiphy jyotiphy requested a review from ZLLentz July 9, 2024 17:22
@jyotiphy
Copy link
Contributor Author

jyotiphy commented Jul 9, 2024

@ZLLentz Changing TermMin value to 0 gives, raw voltage of about -68mV. Phil said that he's expecting ~10mV. 🤔

@ZLLentz
Copy link
Member

ZLLentz commented Jul 9, 2024

Well, that's much better than the -10V we saw before!
Maybe it's worth checking the pins with a multimeter to confirm the behavior?

We need to separate any potential grounding/wiring issues from code issues and address them separately.

@jyotiphy jyotiphy merged commit 4534d47 into pcdshub:master Jul 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants