Fixing epicsarch bug on last alias not having a pv #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Probably should have included this in #219
I'm just checking if key is not empty after the for loop in read_file. If it is, that means we did not encounter a pv after the last alias, and it should be in extraKeys, but was not because the for loop only does so when it encounters the next key (a line that starts with * when key is not empty), which does not work on the last alias.
Motivation and Context
#220
How Has This Been Tested?
Interactively with variations of this arch file
Where Has This Been Documented?
n/a