Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #86 #148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #86 #148

wants to merge 1 commit into from

Conversation

soundarapandian
Copy link
Contributor

Normally links in standard navbar will toggle in mobile devices. So I have placed two different language switch to ensure it displayed correctly in large screen and mobile devices.

Its not the final solution. I have fixed only the design. Attaching few screenshots

desktop-and-tablet

mobile

on-toggle

@soundarapandian
Copy link
Contributor Author

@pcav Its good to merge now.

@pcav
Copy link
Owner

pcav commented Jan 7, 2014

Hi Soundar,
I do not have an infrastructure for testing, so I'm cautious before merging. From the images above, the bahaviour is not the desired one (in fact, the lang switch should not be very prominent, as it should be used only in corner cases, like having a browser in one lang, and wishing to read the site in another one).
Could you please set up a sample site with your modifications, for deeper inspection, or send some updated screeshots?
Thanks.

@soundarapandian
Copy link
Contributor Author

Actually I have fixed what is being discussed here.

#86 (comment). But your comments says lang switch should not be very prominent

Can you please point me the actual problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants