Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: show detailed validation errors in error.cause #6551

Merged
merged 7 commits into from
Jun 28, 2024

Conversation

AlessioGr
Copy link
Member

@AlessioGr AlessioGr commented May 29, 2024

Description

BREAKING: ValidationError now requires the global or collection slug, as well as an errors property. The actual errors are no longer at the top-level.

Now:
CleanShot 2024-05-29 at 11 59 12

Previously, we would have no way to know what the error message was, or in which collection that field resides in

TODO: Include error.cause for pino-logged errors as well, see pinojs/pino-pretty#518

@AlessioGr AlessioGr requested a review from jmikrut June 26, 2024 21:21
Copy link
Member

@denolfe denolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to VaildationError are considered breaking. The description and PR title should be updated accordingly.

@AlessioGr AlessioGr changed the title feat: show detailed validation errors in error.cause feat!: show detailed validation errors in error.cause Jun 28, 2024
@AlessioGr AlessioGr merged commit 8f346df into beta Jun 28, 2024
47 checks passed
@AlessioGr AlessioGr deleted the feat/show-collection-in-validation-error branch June 28, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants