Refactoring/step2 #24
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use of a single-leading underscore as "internal use" indicator.
This was done to improve code clarity and allow unit testing of the function.
- run_persistence replaces RunPersistence - variable names are now lower-case - clusters of lines are compactified
- FilterExtremumPointsByPersistence is now filter_extremum_points_by_persistence - Variable names are now lower-case and employ underscores
- DiversifyExtremumPointsAndPersistence is now diversify_extremum_points_and_persistence - Variable names are now lower-case and employ underscores
Deletion of the function plot_persistence, originally meant to plot persistence diagrams.
Default min_persistence should be 0, which is the lowest possible value. Topological persistence has values in [0, +inf].
This was done to improve code clarity and allow unit testing of the function. The new function, _sort_extrema_by_coordinate, sorts local extremum points w.r.t. Cartesian coordinates rather than their topological persistence.
To improve readibility and simplify unit testing, _find_seeds_in_RoI determines all the seeds that are between two boundary values (which will be the matricial coordinates of a region of interest)
rea1991
added
testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.