Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant \n from critical log messages #44

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

robomics
Copy link
Contributor

No description provided.

@robomics robomics added the bug Something isn't working label Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.25%. Comparing base (0ca970b) to head (446aa78).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/nchg/main.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   74.32%   74.25%   -0.07%     
==========================================
  Files          32       32              
  Lines        4296     4296              
  Branches      445      445              
==========================================
- Hits         3193     3190       -3     
- Misses        850      853       +3     
  Partials      253      253              
Flag Coverage Δ
[tests integration](https://app.codecov.io/gh/paulsengroup/NCHG/pull/44/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 71.67% <0.00%> (-0.08%)
[tests unittests](https://app.codecov.io/gh/paulsengroup/NCHG/pull/44/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 68.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robomics robomics merged commit d22d786 into main Nov 11, 2024
70 of 72 checks passed
@robomics robomics deleted the fix/logging branch November 11, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant