Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of NCHG cartesian-product #43

Merged
merged 18 commits into from
Nov 13, 2024

Conversation

robomics
Copy link
Contributor

The purpose of this command is to take a list of 1D domains in BED3+ format, and generate a list of pairs of domains suitable for NCHG compute.

@robomics robomics added the enhancement New feature or request label Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 69.67213% with 222 lines in your changes missing coverage. Please review.

Project coverage is 74.08%. Comparing base (0ca970b) to head (098f3e3).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
src/nchg/compute/compute.cpp 63.38% 94 Missing and 25 partials ⚠️
src/nchg/cartesian_product/cartesian_product.cpp 70.03% 68 Missing and 21 partials ⚠️
src/nchg/cli.cpp 88.63% 6 Missing and 4 partials ⚠️
src/nchg/common/io_impl.hpp 69.23% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   74.32%   74.08%   -0.24%     
==========================================
  Files          32       34       +2     
  Lines        4296     4924     +628     
  Branches      445      531      +86     
==========================================
+ Hits         3193     3648     +455     
- Misses        850      985     +135     
- Partials      253      291      +38     
Flag Coverage Δ
[tests integration](https://app.codecov.io/gh/paulsengroup/NCHG/pull/43/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 71.83% <69.67%> (+0.09%)
[tests unittests](https://app.codecov.io/gh/paulsengroup/NCHG/pull/43/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 68.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robomics robomics force-pushed the feat/cartesian-product branch 2 times, most recently from 929d7c9 to 4597bd9 Compare November 13, 2024 10:11
@robomics robomics merged commit 733e948 into main Nov 13, 2024
70 of 72 checks passed
@robomics robomics deleted the feat/cartesian-product branch November 13, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant