Address review comments.

paulosjca · Dec 27, 2024 · f41d002 · f41d002
1 parent 8d34959
commit f41d002
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/tools/internal_ci/linux/grpc_e2e_performance_gke.sh b/tools/internal_ci/linux/grpc_e2e_performance_gke.sh
@@ -210,6 +210,10 @@ if [[ -v "useLanguage[ruby]" ]]; then
 fi
 
 # Disable broken tests by regex.
+# The test disabled here hangs on 8 cores. The result of this test is not
+# displayed in the public dashboard. The test runs and passes on the 30-core
+# ("32core") node pool. This can be considered a permanent fix, selectively
+# removing an unnecessary test and allowing the test run to become green.
 declare -a disabledTests8core=(
   cpp_protobuf_async_client_unary_1channel_64wide_128breq_8mbresp_insecure
 )

diff --git a/tools/internal_ci/linux/grpc_e2e_performance_gke_experiment.sh b/tools/internal_ci/linux/grpc_e2e_performance_gke_experiment.sh
@@ -205,6 +205,10 @@ if [[ -v "useLanguage[ruby]" ]]; then
 fi
 
 # Disable broken tests by regex.
+# The test disabled here hangs on 8 cores. The result of this test is not
+# displayed in the public dashboard. The test runs and passes on the 30-core
+# ("32core") node pool. This can be considered a permanent fix, selectively
+# removing an unnecessary test and allowing the test run to become green.
 declare -a disabledTests8core=(
   cpp_protobuf_async_client_unary_1channel_64wide_128breq_8mbresp_insecure
 )