Skip to content

Commit

Permalink
[Python Otel] Deprecate target_attribute_filter (grpc#36697)
Browse files Browse the repository at this point in the history
We decided to deprecate `target_attribute_filter` in grpc/proposal#431.

This PR marks the attribute as deprecated.

<!--

If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the appropriate
lang label.

-->

Closes grpc#36697

COPYBARA_INTEGRATE_REVIEW=grpc#36697 from XuanWang-Amos:deprecate_target_filter 9954bb4
PiperOrigin-RevId: 636304089
  • Loading branch information
XuanWang-Amos authored and copybara-github committed May 22, 2024
1 parent 44b7631 commit 46d864a
Showing 1 changed file with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,10 @@ def __init__(
enabled for this OpenTelemetryPlugin.
meter_provider: A MeterProvider which will be used to collect telemetry data,
or None which means no metrics will be collected.
target_attribute_filter: Once provided, this will be called per channel to decide
whether to record the target attribute on client or to replace it with "other".
target_attribute_filter: [DEPRECATED] This attribute is deprecated and should
not be used.
Once provided, this will be called per channel to decide whether to record the
target attribute on client or to replace it with "other".
This helps reduce the cardinality on metrics in cases where many channels
are created with different targets in the same binary (which might happen
for example, if the channel target string uses IP addresses directly).
Expand Down

0 comments on commit 46d864a

Please sign in to comment.