Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix or ignore broken JavadocParanamer tests #44

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix or ignore broken JavadocParanamer tests #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2c851e
Fix Java SE 5-7 URLs; Fix Paranamer Javadoc file reference
mjustin Aug 29, 2021
442f27c
Ignore tests with non-trivial fixes
mjustin Aug 29, 2021
2444fa4
Don't depend on artifact version number in test
mjustin Aug 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions paranamer/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@
<includeArtifactIds>arpack_combined_all,${project.artifactId}</includeArtifactIds>
<failOnMissingClassifierArtifact>true</failOnMissingClassifierArtifact>
<outputDirectory>${project.build.directory}/test-data</outputDirectory>
<stripVersion>true</stripVersion>
</configuration>
</execution>
</executions>
Expand Down
32 changes: 25 additions & 7 deletions paranamer/src/test/com/thoughtworks/paranamer/JavadocParanamerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,14 @@
*/
public class JavadocParanamerTest extends AbstractParanamerTestCase {

private static final String JAVADOCS_3 = "http://docs.oracle.com/javase/1.3/docs/api/";
private static final String JAVADOCS_4 = "http://docs.oracle.com/javase/1.4.2/docs/api/";
private static final String JAVADOCS_5 = "http://docs.oracle.com/javase/1.5.0/docs/api/";
private static final String JAVADOCS_6 = "http://docs.oracle.com/javase/6/docs/api/";
private static final String JAVADOCS_7 = "http://docs.oracle.com/javase/7/docs/api/";
private static final String JAVADOCS_3 = "https://docs.oracle.com/javase/1.3/docs/api/";
private static final String JAVADOCS_4 = "https://docs.oracle.com/javase/1.4.2/docs/api/";
private static final String JAVADOCS_5 = "https://docs.oracle.com/javase/1.5.0/docs/api/";
private static final String JAVADOCS_6 = "https://docs.oracle.com/javase/6/docs/api/";
private static final String JAVADOCS_7 = "https://docs.oracle.com/javase/7/docs/api/";

private static final String JAVADOCS_F2J = "http://icl.cs.utk.edu/projectsfiles/f2j/javadoc/";
private static final String JAVADOCS_F2J_FILE = "paranamer/target/test-data/arpack_combined_all-0.1-javadoc.jar";
private static final String JAVADOCS_F2J_FILE = "paranamer/target/test-data/arpack_combined_all-javadoc.jar";

private static final String JAVADOCS_4_PARTIAL_DIR = "paranamer/src/resources/javadocs/jdk1.4/docs";
private static final String JAVADOCS_5_PARTIAL_DIR = "paranamer/src/resources/javadocs/jdk5/docs";
Expand All @@ -70,7 +70,7 @@ public class JavadocParanamerTest extends AbstractParanamerTestCase {
private static final String JAVADOCS_6_PARTIAL_ZIP = "paranamer/src/resources/javadocs/jdk6.zip";
private static final String JAVADOCS_7_PARTIAL_ZIP = "paranamer/src/resources/javadocs/jdk7.zip";

private static final String JAVADOCS_PARANAMER_FILE = "paranamer/target/test-data/paranamer-2.5.5-javadoc.jar";
private static final String JAVADOCS_PARANAMER_FILE = "paranamer/target/test-data/paranamer-javadoc.jar";

@Before
public void setUp() throws Exception {
Expand All @@ -89,6 +89,20 @@ public void testLookupParameterNamesForMethodWhenNoArg() throws Exception {
public void testLookupParameterNamesForPrivateMethod() throws Exception {
}

@Test
@Ignore("no longer working working with currently generated Javadocs")
@Override
public void testLookupParameterNamesForConstructorWithStringArg() throws Exception {
super.testLookupParameterNamesForConstructorWithStringArg();
}

@Test
@Ignore("no longer working working with currently generated Javadocs")
@Override
public void testLookupParameterNamesForInterfaceMethod() throws Exception {
super.testLookupParameterNamesForInterfaceMethod();
}

@Test(expected = FileNotFoundException.class)
public void failsIfBadInput() throws Exception {
new JavadocParanamer(new URL(JAVADOCS_7 + "/DOES_NOT_EXIST"));
Expand All @@ -105,6 +119,7 @@ public void failsIfNotAJavadocDirectory() throws Exception {
}

@Test
@Ignore("these files are no longer in the repo for license reasons")
public void dirParanamer() throws Exception {
testJavaIoFile(JAVADOCS_4_PARTIAL_DIR);
testJavaIoFile(JAVADOCS_5_PARTIAL_DIR);
Expand All @@ -113,6 +128,7 @@ public void dirParanamer() throws Exception {
}

@Test
@Ignore("these files are no longer in the repo for license reasons")
public void fileParanamer() throws Exception {
testJavaIoFile(JAVADOCS_4_PARTIAL_ZIP);
testJavaIoFile(JAVADOCS_5_PARTIAL_ZIP);
Expand All @@ -121,11 +137,13 @@ public void fileParanamer() throws Exception {
}

@Test
@Ignore("Java 3 Javadocs are no longer hosted by Oracle except as downloadable archive")
public void javadocs3() throws Exception {
testJavaUtilUrl(JAVADOCS_3);
}

@Test
@Ignore("Java 4 Javadocs are no longer hosted by Oracle except as downloadable archive")
public void javadocs4() throws Exception {
testJavaUtilUrl(JAVADOCS_4);
}
Expand Down