Add support for React 18 #3203
Add support for React 18 #3203
Conversation
| const renderFn = isProd ? ReactDOM.hydrate : ReactDOM.render; | ||
| renderFn(<App />, document.getElementById('root')); | ||
| const container = document.getElementById('root'); | ||
| // TODO: Enable StrictMode: https://reactjs.org/docs/strict-mode.html |
There was a problem hiding this comment.
Enabling strict mode here seems to break the navigation, so I have omitted it in this PR. I've created an issue to deal with this at a later point (#3204).
There was a problem hiding this comment.
Yeah since PF is built with so many PF components, and there are a number of issues with strict mode in PF-react right now, it may be a time before we can enable strict mode in org.
There was a problem hiding this comment.
@nicolethoen note that this is React Strict Mode, not TypeScript strict mode we're talking about.
|
PF4 preview: https://patternfly-org-pr-3203-v4.surge.sh/v4 |
|
LGTM |
|
@jonkoops once you rebase and update the commit message, we can merge this |
|
Done 👍 |
|
@dgutride @wise-king-sullyman @dlabaj I wanted to get your eyes on this as the docs-framework is no longer used just for the PF website docs but is the basis for all PF extension docs moving forward. Based on the potential impact to extensions do you have feedback on this PR to support React 18? |
|
I did a quick test in the extracted catalog view repo by pulling this branch and using @jonkoops do you have any guesses as to the issue here? What I've found on Stack Overflow so far suggests that the issue is usually caused by using a React version < 18, but the extracted catalog view is already using React 18. |
|
I'm also concerned that if this presents a breaking change for patternfly-react to consume the documentation framework, that we'd only be able to consume this doc-framework update in the v5 branch and will mean we cannot consume any updates to the documentation framework in v4 going forward. that sounds like it might be a problem. I'll check out trying to use this updated version in patternfly-react's v4 branch and see what happens |
|
We might need to wait to merge this until we are able to create a PFv4 branch the documentation framework. I'll loop back around when the decisions about v4 are made |
Adds support for React 18 and applies the migrations as stated in the migration guide. This change is part of a greater effort to land React 18 support in Patternfly (patternfly/patternfly-react#7142).