Skip to content

Commit

Permalink
Merge pull request #8 from patricklx/fix-controller-arg
Browse files Browse the repository at this point in the history
fix controller arg
  • Loading branch information
patricklx authored Mar 18, 2024
2 parents 6572f86 + a3dce3d commit 3dbe025
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 19 deletions.
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ jobs:
fail-fast: false
matrix:
try-scenario:
- ember-lts-3.28
- ember-lts-4.4
- ember-lts-4.8
- ember-lts-4.12
Expand Down
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
import { precompileTemplate } from '@ember/template-compilation';
export default precompileTemplate("<this.Component @model={{this.model}} @controller={{this.controller}} />");
export default precompileTemplate("<this.Component @model={{this.model}} @controller={{this}} />");
17 changes: 0 additions & 17 deletions test-app/config/ember-try.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,23 +7,6 @@ module.exports = async function () {
return {
usePnpm: true,
scenarios: [
{
name: 'ember-lts-3.28',
npm: {
devDependencies: {
// sketchy town!
// ember-source has a check for this.project.bowerDependencies()
// which was removed in ember-cli 5. not sure if swapping out
// ember-cli with ember-try (which is itself running on the
// currently installed ember-cli version) is really ok, but it
// seems to work?
'ember-cli': '~4.12.0',
'ember-source': '~3.28.0',
'ember-qunit': '~6.2.0',
'@ember/test-helpers': '~2.9.4',
},
},
},
{
name: 'ember-lts-4.4',
npm: {
Expand Down

0 comments on commit 3dbe025

Please sign in to comment.