Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RecordService import #87

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Update RecordService import #87

merged 4 commits into from
Oct 30, 2023

Conversation

seofernando25
Copy link
Contributor

Fixes #86

@seofernando25 seofernando25 marked this pull request as draft October 28, 2023 23:54
@seofernando25
Copy link
Contributor Author

Oops need to update pkg ver

@seofernando25 seofernando25 marked this pull request as ready for review October 28, 2023 23:58
patmood
patmood reviewed Oct 29, 2023
View reviewed changes
Copy link
Owner

@patmood patmood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just need to remove the ci dependency I think

package.json Outdated
@@ -33,6 +33,7 @@
"author": "@patmood",
"license": "ISC",
"dependencies": {
"ci": "^2.3.0",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is breaking the github actions. Is it necessary?

Copy link
Contributor Author

@seofernando25 seofernando25 Oct 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh oh... so sorry about that, I don't remember making this change.

I think I ran npm i ci by accident instead of npm ci

@patmood
Copy link
Owner

patmood commented Oct 29, 2023

Just need to update a couple of snapshots with npm run test:update. By running the test suite it'll also generate a new example output, which should make the integration tests pass too 👍

@seofernando25
Copy link
Contributor Author

Oh you have snapshots! Cool I wasn't aware of that.

@seofernando25 seofernando25 requested a review from patmood October 29, 2023 16:57
@patmood patmood merged commit b50cdb8 into patmood:main Oct 30, 2023
2 checks passed
@patmood
Copy link
Owner

patmood commented Oct 30, 2023

Thanks for the contribution!

@seofernando25 seofernando25 deleted the patch-1 branch October 30, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patmood patmood Awaiting requested review from patmood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RecordService type import should be outside brackets
2 participants
@seofernando25 @patmood