Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Partially fix GPSR for HamEvo #384

Merged
merged 2 commits into from
May 16, 2024
Merged

[Bug] Partially fix GPSR for HamEvo #384

merged 2 commits into from
May 16, 2024

Conversation

jpmoutinho
Copy link
Collaborator

@jpmoutinho jpmoutinho commented Apr 9, 2024

Originally this MR was related to #397

Decided to simplify it since properly making all other changes caused other issues.

@jpmoutinho jpmoutinho self-assigned this Apr 9, 2024
@RolandMacDoland
Copy link
Collaborator

Hey @jpmoutinho is this reviewable/mergeable ?

@jpmoutinho
Copy link
Collaborator Author

Not yet @Roland-djee. I'm currently looking at the GPSR implementation to see how to properly account for that here.

@jpmoutinho jpmoutinho reopened this May 16, 2024
@jpmoutinho jpmoutinho changed the title [Refact] Reviewing block generators [Bug] Partially fix GPSR for HamEvo May 16, 2024
@jpmoutinho jpmoutinho marked this pull request as ready for review May 16, 2024 15:00
@RolandMacDoland RolandMacDoland self-requested a review May 16, 2024 15:04
Copy link
Collaborator

@RolandMacDoland RolandMacDoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@jpmoutinho jpmoutinho merged commit 04c0bac into main May 16, 2024
8 checks passed
@jpmoutinho jpmoutinho deleted the jm/generators branch May 16, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants