Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proto] Implement a State result type. #377

Closed
wants to merge 1 commit into from
Closed

[Proto] Implement a State result type. #377

wants to merge 1 commit into from

Conversation

RolandMacDoland
Copy link
Collaborator

Closes #376

@RolandMacDoland RolandMacDoland self-assigned this Mar 26, 2024
@RolandMacDoland
Copy link
Collaborator Author

@jpmoutinho @dominikandreasseitz I know lint/test fail but works for PyQ. Just for you to tell me what you think about it.

dominikandreasseitz
dominikandreasseitz reviewed Mar 27, 2024
View reviewed changes
qadence/types.py
samples: list[Counter]


@dataclass(frozen=True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about expectation values? also, this would change the convenient torch-like interface quite a bit since you cant use autograd on outputs of qadence methods anymore

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess expectation values can stay a Tensor I guess ? I don't know of any user request to post-process expectation values yet.

Sure but that is the price to pay for having an intermediate State data structure. I know this is breaking but hopefully not too much.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A probably less disruptive solution would be to subclass Tensor. WDYT @dominikandreasseitz ?

@dominikandreasseitz dominikandreasseitz marked this pull request as draft April 12, 2024 11:22
@RolandMacDoland RolandMacDoland mentioned this pull request Apr 23, 2024
Closed
3 tasks
@RolandMacDoland
Copy link
Collaborator Author

Closing as moved elsewhere.

@Doomsk Doomsk mentioned this pull request May 24, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikandreasseitz dominikandreasseitz dominikandreasseitz left review comments

@jpmoutinho jpmoutinho Awaiting requested review from jpmoutinho

Assignees

@RolandMacDoland RolandMacDoland

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Proto] Implement a State result type
2 participants
@RolandMacDoland @dominikandreasseitz