Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refact] Reviewing block generators #397

Closed
RolandMacDoland opened this issue Apr 26, 2024 · 3 comments
Closed

[Refact] Reviewing block generators #397

RolandMacDoland opened this issue Apr 26, 2024 · 3 comments
Assignees
Labels
refactoring Refactoring of legacy code to_check To check in the development of the new expression system.

Comments

@RolandMacDoland
Copy link
Collaborator

RolandMacDoland commented Apr 26, 2024

Related to #266

All unitary operators have an hermitian generator such that
$$\hat{U}=exp(-i\hat{H})$$
In Qadence we have block.generator which is supposed to return $\hat{H}$. However, if we want to use HamEvo to then represent the original unitary, we have to specify a time value since it implements $exp(-i\hat{H}t)$. Currently, some blocks seems to have some inconsistent definitions.

This also affects GPSR, since there the paper assumes a generator structure of $exp(-iG/2x)$ for some gate $U(x)$.

Probable requirements:

@RolandMacDoland RolandMacDoland added the refactoring Refactoring of legacy code label Apr 26, 2024
@jpmoutinho jpmoutinho added the to_check To check in the development of the new expression system. label May 14, 2024
@RolandMacDoland
Copy link
Collaborator Author

@jpmoutinho You mentioned something about it in the planning, right ?

@jpmoutinho
Copy link
Collaborator

@Roland-djee yes, for @chMoussa to be aware of this while planning how GPSR is integrated into pyqtorch

@chMoussa
Copy link
Collaborator

chMoussa commented Aug 9, 2024

Closing with #526

@chMoussa chMoussa closed this as completed Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring of legacy code to_check To check in the development of the new expression system.
Projects
None yet
Development

No branches or pull requests

3 participants