Misc cleanup of errors and docs #1720
Conversation
| @@ -38,7 +38,7 @@ public static class StructField extends AstNode { | |||
|
|
|||
| private final boolean optional; | |||
|
|
|||
| @Nullable | |||
| @NotNull | |||
There was a problem hiding this comment.
(self-review) lists should be @NotNull rather than @Nullable. Taken from #1692
| val dividendStr = prepare(dividend.toString(), " -- ", " / 0") | ||
| return "Division$dividendTypeStr by zero$dividendStr$dividendTypeStr." | ||
| val dividendStr = prepare(dividend.toString(), " ") | ||
| return "Cannot divide$dividendStr$dividendTypeStr by zero." |
There was a problem hiding this comment.
(self-review) error message follows what's suggested from PError. This new error allows for reuse for / and %. Also the 0 may be a decimal or floating point zero.
| @@ -15,7 +15,8 @@ public class Identifier private constructor( | |||
| ) : Iterable<Identifier.Simple> { | |||
|
|
|||
| /** | |||
| * Returns the unqualified name part. | |||
| * Returns the right-most simple identifier of the qualified identifier. For example, for an identifier | |||
There was a problem hiding this comment.
(self-review) copied from AST's Identifier javadoc
CROSS-ENGINE-REPORT ❌
Testing Details
Result Details
Now FAILING Tests ❌The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. Now IGNORED Tests ❌The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. Now Passing Tests180 test(s) were previously failing in BASE (LEGACY-V0.14.8) but now pass in TARGET (EVAL-7457A13). Before merging, confirm they are intended to pass. The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. |
|
New conformance tests are unrelated to this PR's changes. See this PR's conformance summary -- https://github.com/partiql/partiql-lang-kotlin/actions/runs/12838981007/attempts/1#summary-35805684691 See other PR's conformance summary which just updates partiql-tests (to the version in this PR) -- https://github.com/partiql/partiql-lang-kotlin/actions/runs/12838851749/attempts/1#summary-35805197280 |
alancai98
force-pushed
the
more-cleanup
branch
from
ef0aaac to
b799641
Compare
Relevant Issues
Description
/and%/and%of decimals + numericsLicense Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.