Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Flpath 530 rebase on upgraded-spring #487

Merged

Conversation

RichardW98
Copy link
Contributor

What this PR does / why we need it:
Flpath 530 rebase on upgraded-spring
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story (FLPATH-xxxx):
Fixes #

Change type

  • New feature
  • Bug fix
  • Unit tests
  • Integration tests
  • CI
  • Documentation
  • Auto-generated SDK code

Impacted services

  • Workflow Service
  • Notification Service

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

eloycoto and others added 3 commits July 31, 2023 12:52
These changes are not definitive, and it's just a quick fix for a user
POC. The idea is still moving to openid.

- Using LDAP env variables in the config makes it easy for users to move
  things around.
- Disable example app-config to be able to log in as multiple users.

Signed-off-by: Eloy Coto <[email protected]>
@anludke
Copy link
Contributor

anludke commented Jul 31, 2023

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anludke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 744d32a into parodos-dev:FLPATH-530 Jul 31, 2023
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants