Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract block announce validation from ChainSync #1170

Merged

Conversation

dmitry-markin
Copy link
Contributor

This PR is part of Sync 2.0 preparation work. Resolves #503.

Supersedes paritytech/substrate#14675, please see the discussion there for details.

@dmitry-markin dmitry-markin added the R0-silent Changes should not be mentioned in any release notes label Aug 25, 2023
@dmitry-markin dmitry-markin marked this pull request as ready for review August 25, 2023 14:58
@altonen
Copy link
Contributor

altonen commented Sep 4, 2023

Any reason this isn't merged yet?

@dmitry-markin
Copy link
Contributor Author

Any reason this isn't merged yet?

Last week one zombienet test was failing (I guess on master too), so I've been waiting for the CI to turn green.

@dmitry-markin
Copy link
Contributor Author

dmitry-markin commented Sep 4, 2023

And now Check Markdown test is failing 🙈

EDIT: restart helped.

@dmitry-markin dmitry-markin merged commit 01cdae8 into master Sep 4, 2023
5 checks passed
@dmitry-markin dmitry-markin deleted the dm-extract-block-announce-validation-from-chainsync branch September 4, 2023 15:27
ordian added a commit that referenced this pull request Sep 6, 2023
* master: (24 commits)
  GHW for building and publishing docker images (#1391)
  pallet asset-conversion additional quote tests (#1371)
  Remove deprecated `pallet_balances`'s `set_balance_deprecated` and `transfer` dispatchables (#1226)
  Fix PRdoc check (#1419)
  Fix the wasm runtime substitute caching bug (#1416)
  Bump enumn from 0.1.11 to 0.1.12 (#1412)
  RFC 14: Improve locking mechanism for parachains (#1290)
  Add PRdoc check (#1408)
  fmt fixes (#1413)
  Enforce a decoding limit in MultiAssets (#1395)
  Remove dynamic dispatch using `Ext` (#1399)
  Remove redundant calls to `borrow()` (#1393)
  Get rid of polling in `WarpSync` (#1265)
  Bump actions/checkout from 3 to 4 (#1398)
  Bump thiserror from 1.0.47 to 1.0.48 (#1396)
  Move Relay-Specific Shared Code to One Place (#1193)
  rust docs: add simple analytics (#1377)
  Contracts: Update read_sandbox (#1390)
  Extract block announce validation from `ChainSync` (#1170)
  [ci] Remove runtime-benchmarks from tests (#1335)
  ...
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
* register parachain relay subcommand

* revert cargo patch

* added basic test

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
* register parachain relay subcommand

* revert cargo patch

* added basic test

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
* register parachain relay subcommand

* revert cargo patch

* added basic test

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
* register parachain relay subcommand

* revert cargo patch

* added basic test

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
* register parachain relay subcommand

* revert cargo patch

* added basic test

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
* register parachain relay subcommand

* revert cargo patch

* added basic test

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
* register parachain relay subcommand

* revert cargo patch

* added basic test

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
* register parachain relay subcommand

* revert cargo patch

* added basic test

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
* register parachain relay subcommand

* revert cargo patch

* added basic test

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
* register parachain relay subcommand

* revert cargo patch

* added basic test

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
* register parachain relay subcommand

* revert cargo patch

* added basic test

* fmt
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
* register parachain relay subcommand

* revert cargo patch

* added basic test

* fmt
bkchr pushed a commit that referenced this pull request Apr 10, 2024
* register parachain relay subcommand

* revert cargo patch

* added basic test

* fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Move block announce validation/polling to SyncingEngine
3 participants