Sanitize target name before resolving #9905
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Closes #9001
Before this PR, parcel will throw an error when target name contains slash. To fix this, we wrap
targetName
withencodeJSONKeyComponent
so that the slash gets encoded properly.💻 Examples
Previously, this error would pop up:
Error: Cannot use 'in' operator to search for 'key' in undefined
✔️ PR Todo