Load graphs on request for Parcel-query #9443
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Parcel-query currently uses loadGraphs to load all of Parcel’s graphs at startup. This PR modifies Parcel-query to only load the graphs required for the query being performed for performance improvements.
💻 Examples
For example, instead of calling
loadGraphon startup which loads all of Parcel's graphs, only the necessary graph will be loaded. In the case of getBundles, thebundleGraphandbundleInfo(and thusrequestTracker) are needed, but theassetGraphis not so that graph is not loaded.🚨 Test instructions
Tested Parcel-queries such as
getBundles,inspectCache, etc. manually on a cache produced by a full build of Jira Frontend.✔️ PR Todo