Query builder #30

Frenkiee · 2021-03-11T17:37:50Z

Defined QueryBuilder page with next content:

The main page container component is QueryLoader. Its purpose is to load the PQL statement from the URL, converting it and switching between Loading, Error, and QueryController states.

QueryController controllers the full page. It holds all the important states:

result
config id
project name <- maybe we can encode it in PQL string**
PQL - in string format
data - Query Data
show result - toggle between showing the result and code
selector - points which selector to open: Operator or Loader
view - toggle between Pql pipeline, Selection, and Configuration

With the state information, it then connects QueryHeader, QueryBuilderHeader, Pql pipeline, QuerySelector, OperationConfig.

PQL state interface is defined in state/pql/*.

The most important thing in this architecture is QueryData from query-builder.ts.
You can notice that the ExtendedOpeator uses Operator instance, which needs to be an object!
Because the operator is an object, values are not updated in React style with setState(), but are rather mutated internally.
The structure is prepared in a Builder pattern from objective-oriented (OO) programming principles.
This allows us to easily create new operators without changing the current structure.

From the structure can be also seen that the AggregationOperator is an "outside" operator. It is a bit hacky solution, which needs to be modified in the future (when we will add validation and some other stuff at the end of the pipeline). But the current structure satisfies functionality for the current PQL structure.

Loaders (src/pages/query/builder/loaders/*):

HttpGetLoader
HttpPostLoader
PostgressLoader
EthereumBalanceLoader
EthereumFunctionLoader

Operators(src/pages/query/builder/operators):

AggregateOperator (OutsideOperator)
GetIndexOperator
MathOperator
QuerySqlOperator
TraverseOperator

To update the Operator parameters OperatorConfig component has refresh functionality, which allows us to pass the refresh function callback into the Operator and it can trigger it every time the change is made.

- Defined access and refresh tokens - Prepared interceptor for obtaining new access token or redirecting to the login page when refresh token is expired

…page has defined custom variable URL

…ifications

Available email: [email protected], password: geslo123

…is defined routes are protected by checking if user is logged in and if we have access token defined

…moved into Page component

… (cpu -> 700%). Add * to disable lint.

…moved into src/pql folder

… process moved to pre-push

…ately

… can now manage AggregatorOperator

… and added addOrConfigAggregator, build, compileToPql, run, save methods

…ated with new concept

Netherdrake · 2021-03-11T20:01:08Z

src/api/auth.ts

+const loginUser = (data: UserAuthenticationData): Promise<void> => {
+  const { email, password } = data;
+
+  if (email !== '[email protected]') throw new Error('Email does not exist!');


I'm confused about why do we have login. Also why is it hardcoded?

It is a skeleton for an API function call with hardcoded error handling to see how the components react. Will add the connection. Also, It would been good to have both access and refresh tokens for JWT authentication. I think currently only access token is available.

Frenkiee · 2021-03-11T22:55:57Z

src/components/common/Buttons.tsx

+const GRAY_COLOR = 'gray';
+const RED_COLOR = 'red';
+
+type Color = typeof BLUE_COLOR | typeof GREEN_COLOR | typeof GRAY_COLOR | typeof RED_COLOR;


Color should be an enum

Hmm we will keep this solution so the Button color can be called by string

Frenkiee · 2021-03-11T23:07:19Z

src/components/pages/query/selectors/QuerySelector.tsx

+    case SELECTOR_OPERATOR:
+      return <OperationSelector onClose={onClose} addOperator={addOperator} />;
+    default:
+      return <OperationSelector onClose={onClose} addOperator={addOperator} />;


the default should throw an error

jbargu · 2021-03-12T06:44:54Z

I get bunch of warnings when trying to start this with yarn start:

Failed to compile.

src/components/common/Inputs.tsx
  Line 7:3:    'type' PropType is defined but prop is never used                                          react/no-unused-prop-types
  Line 7:3:    propType "type" is not required, but has no corresponding defaultProps declaration         react/require-default-props
  Line 7:3:    propType "type" is not required, but has no corresponding defaultProps declaration         react/require-default-props
  Line 8:3:    propType "className" is not required, but has no corresponding defaultProps declaration    react/require-default-props
  Line 8:3:    propType "className" is not required, but has no corresponding defaultProps declaration    react/require-default-props
  Line 9:3:    propType "placeholder" is not required, but has no corresponding defaultProps declaration  react/require-default-props
  Line 9:3:    propType "placeholder" is not required, but has no corresponding defaultProps declaration  react/require-default-props
  Line 24:3:   propType "className" is not required, but has no corresponding defaultProps declaration    react/require-default-props
  Line 28:3:   A form label must be associated with a control                                             jsx-a11y/label-has-associated-control
  Line 55:25:  Missing return type on function                                                            @typescript-eslint/explicit-function-return-type
  Line 55:47:  'Checkbox' is assigned a value but never used                                              @typescript-eslint/no-unused-vars
  Line 69:25:  Missing return type on function                                                            @typescript-eslint/explicit-function-return-type
  Line 69:47:  'Textarea' is assigned a value but never used                                              @typescript-eslint/no-unused-vars

src/components/common/Lists.tsx
  Line 10:65:  'ListHeaderAddRemove' is assigned a value but never used  @typescript-eslint/no-unused-vars
  Line 11:3:   'React' must be in scope when using JSX                   react/react-in-jsx-scope
  Line 12:5:   'React' must be in scope when using JSX                   react/react-in-jsx-scope
  Line 14:5:   'React' must be in scope when using JSX                   react/react-in-jsx-scope
  Line 15:7:   'React' must be in scope when using JSX                   react/react-in-jsx-scope
  Line 16:7:   'React' must be in scope when using JSX                   react/react-in-jsx-scope

src/components/pages/query/QueryBase.tsx
  Line 2:10:  'Pql' is defined but never used  @typescript-eslint/no-unused-vars

src/components/pages/query/QueryClosableContainer.tsx
  Line 5:1:  `semantic-ui-react` import should occur before import of `../../common/Buttons`  import/order

src/components/pages/query/builder/PqlPipeline.tsx
  Line 1:17:   'useEffect' is defined but never used  @typescript-eslint/no-unused-vars
  Line 1:28:   'useState' is defined but never used   @typescript-eslint/no-unused-vars
  Line 57:27:  Missing return type on function        @typescript-eslint/explicit-function-return-type
  Line 60:22:  Missing return type on function        @typescript-eslint/explicit-function-return-type
  Line 76:29:  Missing return type on function        @typescript-eslint/explicit-function-return-type
  Line 83:26:  Curly braces are unnecessary here      react/jsx-curly-brace-presence

src/components/pages/query/builder/loaders/EthereumBalanceLoader.tsx
  Line 2:10:   'BlockType' is defined but never used        @typescript-eslint/no-unused-vars
  Line 40:22:  Arrow function should not return assignment  no-return-assign
  Line 41:24:  Arrow function should not return assignment  no-return-assign
  Line 42:22:  Missing return type on function              @typescript-eslint/explicit-function-return-type
  Line 42:22:  Arrow function should not return assignment  no-return-assign
  Line 42:55:  Missing radix parameter                      radix
  Line 43:35:  Missing return type on function              @typescript-eslint/explicit-function-return-type
  Line 43:35:  Arrow function should not return assignment  no-return-assign
  Line 44:34:  Missing radix parameter                      radix

src/components/pages/query/builder/loaders/EthereumFunctionLoader.tsx
  Line 4:10:   'BlockType' is defined but never used        @typescript-eslint/no-unused-vars
  Line 5:10:   'Button' is defined but never used           @typescript-eslint/no-unused-vars
  Line 57:22:  Arrow function should not return assignment  no-return-assign
  Line 58:25:  Arrow function should not return assignment  no-return-assign
  Line 59:24:  Arrow function should not return assignment  no-return-assign
  Line 60:22:  Missing return type on function              @typescript-eslint/explicit-function-return-type
  Line 60:22:  Arrow function should not return assignment  no-return-assign
  Line 60:55:  Missing radix parameter                      radix
  Line 61:35:  Missing return type on function              @typescript-eslint/explicit-function-return-type
  Line 61:35:  Arrow function should not return assignment  no-return-assign
  Line 62:34:  Missing radix parameter                      radix
  Line 64:23:  Arrow function should not return assignment  no-return-assign
  Line 66:45:  Arrow function should not return assignment  no-return-assign
  Line 69:16:  Do not use Array index in keys               react/no-array-index-key

src/components/pages/query/builder/loaders/HttpGetLoader.tsx
  Line 26:20:  Arrow function should not return assignment  no-return-assign

src/components/pages/query/builder/loaders/HttpPostLoader.tsx
  Line 5:10:   'Button' is defined but never used           @typescript-eslint/no-unused-vars
  Line 37:20:  Arrow function should not return assignment  no-return-assign
  Line 39:23:  Arrow function should not return assignment  no-return-assign
  Line 41:54:  Arrow function should not return assignment  no-return-assign
  Line 44:16:  Do not use Array index in keys               react/no-array-index-key

src/components/pages/query/builder/loaders/PostgresLoader.tsx
  Line 30:20:  Arrow function should not return assignment  no-return-assign
  Line 31:22:  Arrow function should not return assignment  no-return-assign

src/components/pages/query/builder/operators/AggregateOperator.tsx
  Line 37:27:  Arrow function should not return assignment  no-return-assign
  Line 38:28:  Arrow function should not return assignment  no-return-assign
  Line 39:27:  Arrow function should not return assignment  no-return-assign

src/components/pages/query/builder/operators/GetIndexOperator.tsx
  Line 25:22:  Arrow function should not return assignment  no-return-assign
  Line 25:64:  Missing radix parameter                      radix

src/components/pages/query/builder/operators/MathOperator.tsx
  Line 34:28:  Missing return type on function              @typescript-eslint/explicit-function-return-type
  Line 34:28:  Arrow function should not return assignment  no-return-assign
  Line 35:30:  Arrow function should not return assignment  no-return-assign
  Line 36:31:  Arrow function should not return assignment  no-return-assign

src/components/pages/query/builder/operators/QuerySqlOperator.tsx
  Line 2:20:   'Input' is defined but never used            @typescript-eslint/no-unused-vars
  Line 33:27:  Missing return type on function              @typescript-eslint/explicit-function-return-type
  Line 33:27:  Arrow function should not return assignment  no-return-assign
  Line 34:28:  Arrow function should not return assignment  no-return-assign
  Line 35:28:  Missing return type on function              @typescript-eslint/explicit-function-return-type
  Line 35:28:  Arrow function should not return assignment  no-return-assign

src/components/pages/query/builder/operators/TraverseOperator.tsx
  Line 4:10:   'Button' is defined but never used           @typescript-eslint/no-unused-vars
  Line 5:17:   'Label' is defined but never used            @typescript-eslint/no-unused-vars
  Line 28:23:  Arrow function should not return assignment  no-return-assign
  Line 30:45:  Arrow function should not return assignment  no-return-assign
  Line 33:16:  Do not use Array index in keys               react/no-array-index-key

src/components/pages/query/selectors/LoaderSelector.tsx
  Line 16:26:  Missing return type on function  @typescript-eslint/explicit-function-return-type
  Line 17:27:  Missing return type on function  @typescript-eslint/explicit-function-return-type
  Line 18:28:  Missing return type on function  @typescript-eslint/explicit-function-return-type
  Line 19:29:  Missing return type on function  @typescript-eslint/explicit-function-return-type
  Line 20:30:  Missing return type on function  @typescript-eslint/explicit-function-return-type

src/components/pages/query/selectors/OperationSelector.tsx
  Line 16:27:  Missing return type on function  @typescript-eslint/explicit-function-return-type
  Line 17:27:  Missing return type on function  @typescript-eslint/explicit-function-return-type
  Line 18:23:  Missing return type on function  @typescript-eslint/explicit-function-return-type
  Line 19:27:  Missing return type on function  @typescript-eslint/explicit-function-return-type

src/state/pql/pql.ts
  Line 1:10:  'EOPNOTSUPP' is defined but never used  @typescript-eslint/no-unused-vars

What am I missing?

ZiyedB

1st half of the review, will do the other half later on , but good job so far 👍

ZiyedB · 2021-03-11T18:45:09Z

src/App.tsx

-  const logout = (): void => setUser({ ...emptyUser });
+  const logout = (): void => {
+    setUser({ ...emptyUser });
+    window.location.pathname = LOGIN_PAGE_ROUTE;


should we use history.push ? like built in navigation with react ?

Yes we should, but to access the history we need to place the logout inside the BrowserRouter, else it is undefined

ZiyedB · 2021-03-11T18:46:19Z

src/api/pql.ts

+    .then(() => axiosInstance.get<PQLWithHash>(`/ipfs/${hash}`))
+    .then((res) => res.data);
+
+// TODO Move those two interfaces somewhere


Should we have a folder for interfaces ? those are like harmless to have in one folder in dependencies

Hmm I'm more thinking to replace them and use { result: any } when applying the APICall

ZiyedB · 2021-03-11T18:47:05Z

src/api/pql.ts

+}
+
+export const loadIPFSWithHash = (hash: string): Promise<PQLWithHash> =>
+  Promise.resolve()


Why start with Promise.resolve ?

This is just my preference so that the chain starts with.then, we can skip it if you do not like it

ZiyedB · 2021-03-11T18:48:51Z

src/components/common/Buttons.tsx

+export const Button: React.FC<Button> = ({ children, onClick, color = GRAY_COLOR, className = '' }) => (
+  <button
+    type="button"
+    className={`focus:outline-none text-${color}-600 text-sm py-1.5 px-3 rounded-md border border-${color}-600 hover:bg-${color}-50 ${className}`}


👍 like the color here

ZiyedB · 2021-03-11T18:55:50Z

src/components/common/Inputs.tsx

+}
+
+export const Label = ({ name, className = '' }: Label): JSX.Element => (
+  <label className={`my-auto text-lg font-medium text-gray-700 mr-3 ${className}`} htmlFor="">


Should we add a conditionnal htmlFor in the arguments ? Maybe better to have the for in case

Maybe we can add the argument with the default value

ZiyedB · 2021-03-11T19:01:11Z

src/components/navigation/NavigationBar.tsx

+          <div className="flex-1 flex items-center justify-center sm:items-stretch sm:justify-start">
+            <div className="flex-shrink-0 flex items-center">
+              <img className="block lg:hidden h-8 w-auto" src="/assets/images/logo-icon.png" alt="Workflow" />
+              <img className="hidden lg:block h-8 w-auto" src="/assets/images/logo-icon.png" alt="Workflow" />


what's the difference in between the 2 ? Or is it just for later so we can load two logos based on sreen size ?

this is a copy from tailwindui. didn't play around with it much so will try to remove it

ZiyedB · 2021-03-11T19:06:10Z

src/state/pql/pql.ts

+
+export interface Pql {
+  name: string;
+  psql_version: string; // TODO suggestion: changed from snake cased to camel cased!


agree ! 👍

This needs to be taking care of on BE

ZiyedB · 2021-03-11T19:07:56Z

src/components/pages/ipfs/Ipfs.tsx

+interface UrlParams {
+  hash: string;
+}
+


As general statement,
Let's add some comments on each of the pages and big logic files on what we try to achieve within it,
the more we comment, the more it's accessible to anyone ( it's also easier to review )

Well, my theory about the comments is to comment only on the things that are complicated or on the solutions that are not in the standard form (for example QueryConfig refresh callback). The code should have an understandable meaning by itself and must be written in a readable way with the use of good namings.

https://www.youtube.com/watch?v=7EmboKQH8lM&t=4043s&ab_channel=UnityCoin

ZiyedB · 2021-03-11T19:09:07Z

src/components/pages/ipfs/Ipfs.tsx

+  }, [hash]);
+
+  return error.length > 0 ? (
+    <ErrorContainer message={error} hash={hash} />


For the error we might turn into the notification type of error. Also think we should keep the layout when displaying the error

Agree this was the quick rewritten solution for the previous error handler

ZiyedB · 2021-03-11T19:10:32Z

src/components/pages/query/OperationConfig.tsx

+}
+
+const OperationConfig = ({ onClose, operator }: OperationConfig): JSX.Element => {
+  // Because our operators are not common components, when their state is internally updated


ZiyedB · 2021-03-13T20:38:12Z

src/components/pages/query/builder/PqlPipeline.tsx

+
+type UpdateData = (data: QueryData) => void;
+
+// This function needs to be take care off...


Yup good idea having it maybe in a util that just returns the new state and then we can setData inside the comp ( this way we can as well add a small unit test )

ZiyedB · 2021-03-14T15:13:47Z

src/components/pages/query/builder/compile.ts

+      // If the end operator is not in the current source, find index will return -1,
+      // therefore, we need to update it to the full length of operators
+      // because of the next filter method
+      if (endOperatorIndex === -1) endOperatorIndex = source.operators.length;


source.operators.length - 1 ?
also should we bullet proof if source.operators empty we should have 0 there ?

Yep, it should be -1! will repair it. But still, because of the filter method, this change will not affect the functionality.
The source is never empty. It always has the loader operator inside, else it does not exist.

jbargu

This looks good, nice one! I like how you can run separate steps, see the result and then react accordingly. It needs a bit of UX improvement though. I was a bit confused at first how everything works and which buttons to press:

I would remove the initial "Pipeline 1", "Pipeline 2" JSON for the new PQL definitions made through the query builder. It makes sense for pure JSON editing (to see the example) but for the builder it just gets in the way as you have to remove the steps. I would replace the emptiness with a simple paragraph tutorial:
- "To add an API, click the "Loader" button
- "Click Run to execute the whole query and get the results"
- ... and so on, does not need to be over the top, just the simplest bits of information to get you started
Add a detailed hover text for every button on the toolbar: how does "Build"/"Compile"/"Run" differ from one another? And why should I care as a user? Shouldn't "Run" be all I need from the user perspective?
There was a lot of blank space on the left side when interacting with different components: the JSON editor becomes hidden and if an error occurs, nothing shows up. As a user, I am naturally confused what the heck is going on. Therefore I would have a result/status component always visible on top and then the JSON editor below (ditch the "Show code" button). Even if it is a strange looking error, dump it into the component as it is - no need for fancy formatting - and it will cause less frustration than the white-everything-is-fine type of screen.
When navigating away I can lose everything I made, if I haven't pressed the "Save" button. Add a popup: "Do you really want to leave the screen? Everything you made will be lost." Alternatively, if it is an easy feature to implement, save the structure to local storage whenever a change is made and designate such definitions as a draft.
(nice to have) For every loader/operator/aggregate edit/new menu we can show a simple example below the input fields to show the use of the parameters.

All my remarks are based from the user standpoint of view and are up for discussion. They do not need to be a part of this PR if so desired. Overall the functionality is amazing and very well done! 🚢 🇮🇹

Frenkiee · 2021-03-15T10:53:35Z

@jbargu

Can simply be adjusted on the BE, where you just remove initial pipelines. For the emptiness, are you thinking more of a popup tutorial or more of step by step tutorial: Add API call with and animation points to the Loader, next step to the selection, ...?
We could easily remove the Compile button, but the Build button more or less needs to stay, so the system can apply adjusted Json to the UX structure. About the hovered texts do you maybe have some suggestions on what to write under the Build button? Maybe something like: "Apply JSON to Query"?
There is a "problem" with BE. Sometimes when the query is not "correct" the BE returns an undefined value, which translates into an empty string. Here it would be more convenient to an error or something so the user can see what is going on. As for the "terminal" output view agree it would be nice to have a short output view under the Json editor (like every IDE), but when the user will do "table" queries where the returned data has like 30x100000 outputs it is nice to have a full display of data. Maybe we could create a draggable height for the editor and terminal component, this way we could drop the Code/Result toggle.
Popup feature is a must! As for the save we need an automatic saver, which will save every project on BE. This way the user can any time leave the page and reloads it from the newly-created hash. For this, we would need a Query Hash List page.
Placeholders will be added!

Frenkiee · 2021-03-15T11:31:51Z

What about this UX: when the user leaves the QueryBulder page, the event is triggered, which compiles the Query, saves it, and pushes the notification in what hash the Query was saved successfully. The user can access the hashed Query through the Query Hash List page like in IDE to open up a project.

jbargu · 2021-03-16T09:06:01Z

1. Can simply be adjusted on the BE, where you just remove initial pipelines. For the emptiness, are you thinking more of a popup tutorial or more of step by step tutorial: Add API call with and animation points to the Loader, next step to the selection, ...?

A step-by-step tutorial would be great, but not sure if worth the effort. At the moment I would go for a popup with all the information to get you started. I can see this happening in two possible ways:
1. a simple omni-present component that is a list of bullet points (like in a markdown) on what to press (example PQL defintion), which can be toggled on/off with a click on a "Question mark" button and is present by default when creating a new definition.
2. question marks (optional) added to every component, which show a popup when clicked/tooltip when hovered on.

The first popup would look something like this:

Making PQL definitions is easy when using the query builder. We will create an example PQL that queries the CoinGecko for BTC price.
1. First we need a source of information - a loader. Click on the "Add a loader ..." button in top right
and select a "HTTP Get" button. Copy the CoinGecko URL (https://api.coingecko.com/api/v3/simple/price?ids=bitcoin&vs_currencies=usd) into the URL box and press Submit. A Source-1 step should be added to the list of steps. You can rename the step by clicking on the name and renaming it to "CoinGecko". You can run every step separately by click "Run" button next to the step:
to see the output of every step. To run the whole PQL definition click the big "Run" button:

We can see that the output of the CoinGecko is JSON:
```
{"bitcoin":{"usd":56099}}
```
We have to extract the price by "traversing" the JSON. Let's add a "Traverse" operator:

etc. at this point a user knows how to interact with most basic functionality and can play with other loaders/operators/aggregate. If an example of every operator is not provided when clicking on the operator (placeholder ...) we should list the reference for every operator/loader/aggregate function below:

Operators:

Traverse: allows to traverse the dictionary-like field (such as JSON) given a name. You can specify multiple fields to traverse multiple levels.
Example: `{"first_level: {"second_level": 123456}}`
Result of `Traverse "first_level"` equals to `{"second_level": 123456}`

This is a raw example. What do you think it is the best way?

2. We could easily remove the Compile button, but the Build button more or less needs to stay, so the system can apply adjusted Json to the UX structure. About the hovered texts do you maybe have some suggestions on what to write under the Build button? Maybe something like: "Apply JSON to Query"?

Something like "Build: In case you modified JSON manually in the editor, press this button to update the query builder with the updated values".

3. There is a "problem" with BE. Sometimes when the query is not "correct" the BE returns an undefined value, which translates into an empty string. Here it would be more convenient to an error or something so the user can see what is going on. As for the "terminal" output view agree it would be nice to have a short output view under the Json editor (like every IDE), but when the user will do "table" queries where the returned data has like 30x100000 outputs it is nice to have a full display of data. Maybe we could create a draggable height for the editor and terminal component, this way we could drop the Code/Result toggle.

Dragable windows seem to be a pretty good solution! I would say that the majority of case will still be simple REST requests. Please copy-paste the response/request when BE returns something strange, so we can address it.

4. Popup feature is a must! As for the save we need an automatic saver, which will save every project on BE. This way the user can any time leave the page and reloads it from the newly-created hash. For this, we would need a Query Hash List page.

5. Placeholders will be added!

🎉

What about this UX: when the user leaves the QueryBulder page, the event is triggered, which compiles the Query, saves it, and pushes the notification in what hash the Query was saved successfully. The user can access the hashed Query through the Query Hash List page like in IDE to open up a project.

Yeah, the PQL can be easily saved to IPFS (even if it does not compile, maybe add a Draft label). It would be cool if we could force the local save (without sharing it through the IPFS) but I guess it is not that big of a deal.

ZiyedB and others added 30 commits February 15, 2021 07:56

feat(login): add hook for login + interceptor

34f5931

add check on inputs

e116fc7

packages update

23c46a5

JWT token authentication prepared.

d706210

- Defined access and refresh tokens - Prepared interceptor for obtaining new access token or redirecting to the login page when refresh token is expired

urls.ts is meant to contain all the urs that the app will have. Each …

37dfdec

…page has defined custom variable URL

IPFS and IPFSList components redefined

e7be84c

BaseLayout modified

525fca7

user context state logic moved into state/user.ts with some minor mod…

8db789e

…ifications

Login component updated, it uses some basic logic to login.

824309b

Available email: [email protected], password: geslo123

urls applied in NavigationBar

ea39b07

ProtectedRoute replaced with Page component, which ensures that all h…

9f32b91

…is defined routes are protected by checking if user is logged in and if we have access token defined

Error404 page initialized

a5bd5c2

Authentication and api setup is now in api/api.ts

3e6f6ad

App updated with different user store, urls applied, and some routes …

1e34ede

…moved into Page component

.eslintignore added <- I can not handle lint every save there is made…

ce5e748

… (cpu -> 700%). Add * to disable lint.

IPFS pql/test action fixed

32acf03

Adding keys for each ipfs in list. Hashes are used for keys

1869c65

Baselayout margin changed to padding

8d22894

Redirect to error page where the un-know ipfs hash is opened

c453252

IPFS removed from this issue

6535714

IPFS components upated

34004e1

IPFS and IPFSList components updated in Page

0119028

tailwindui adjusted

932ce3f

Basic api for PQL: runPqlApi and savePqlApi. All PQL interfaces were …

9c9a459

…moved into src/pql folder

Tailwindui configuration, Iconify with material design added and lint…

9c14891

… process moved to pre-push

urls.ts moved to component/routes.ts and components adjusted appropri…

3127520

…ately

authentication api moved in api/ folder

eaa143f

Loading and ErrorContainer created as common components

8e60cf6

Ipfs tailwind small update

c919e4d

Pql interfaces and action creators defined

93efdfd

Frenkiee added 14 commits March 11, 2021 10:18

New AggregateOperator implementing OutsideOperator

5151a1b

QueryData now uses OutsideOperator for aggregate, builder and compile…

d431bf5

… can now manage AggregatorOperator

QueryConfig can now also accept AggregatorOperator

87688d8

QueryController now uses PQL in string, all methods fixed accordingly…

9186875

… and added addOrConfigAggregator, build, compileToPql, run, save methods

Compile the graph before each run

c49a251

partial compile defined

5f45a58

Input onChange function now accepts string. Loaders and Operators upd…

8930190

…ated with new concept

PqlSource and PqlPipeline prepared for partial run

dcde292

Partial run defined

fdfc38a

Pql run api adjusted to accepts any and transforms it into string

3a958bf

linting and pretty-quick

3244d32

lint, prettier, pretty-quick...

d825a24

removed () from closable container

0b4aadb

OperationConfig renamed to OperatorConfig

248280c

Netherdrake requested a review from jbargu March 11, 2021 17:48

Netherdrake reviewed Mar 11, 2021

View reviewed changes

Frenkiee commented Mar 11, 2021

View reviewed changes

ZiyedB reviewed Mar 12, 2021

View reviewed changes

Frenkiee added 5 commits March 12, 2021 13:06

Linting

cfb517e

pql api cleaned

fb558b0

Query section error triggered

68ef775

Lint

0c0c74e

Bug in EthereumFunctionLoader, wrong method

b9bb476

ZiyedB reviewed Mar 14, 2021

View reviewed changes

jbargu approved these changes Mar 15, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Query builder #30

Query builder #30

Frenkiee commented Mar 11, 2021

Netherdrake Mar 11, 2021

Frenkiee Mar 11, 2021

Frenkiee Mar 11, 2021

Frenkiee Mar 12, 2021

Frenkiee Mar 11, 2021

jbargu commented Mar 12, 2021

ZiyedB left a comment

ZiyedB Mar 11, 2021

Frenkiee Mar 12, 2021

ZiyedB Mar 11, 2021

Frenkiee Mar 12, 2021

ZiyedB Mar 11, 2021

Frenkiee Mar 12, 2021

ZiyedB Mar 11, 2021

ZiyedB Mar 11, 2021

Frenkiee Mar 12, 2021

ZiyedB Mar 11, 2021

Frenkiee Mar 12, 2021

ZiyedB Mar 11, 2021

Frenkiee Mar 12, 2021

ZiyedB Mar 11, 2021

Frenkiee Mar 12, 2021

ZiyedB Mar 11, 2021

Frenkiee Mar 12, 2021

ZiyedB Mar 11, 2021

ZiyedB Mar 13, 2021

ZiyedB Mar 14, 2021

Frenkiee Mar 15, 2021

jbargu left a comment

Frenkiee commented Mar 15, 2021

Frenkiee commented Mar 15, 2021

jbargu commented Mar 16, 2021


		type UpdateData = (data: QueryData) => void;

		// This function needs to be take care off...

Query builder #30

Are you sure you want to change the base?

Query builder #30

Conversation

Frenkiee commented Mar 11, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jbargu commented Mar 12, 2021

ZiyedB left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jbargu left a comment

Choose a reason for hiding this comment

Frenkiee commented Mar 15, 2021

Frenkiee commented Mar 15, 2021

jbargu commented Mar 16, 2021

Traverse: allows to traverse the dictionary-like field (such as JSON) given a name. You can specify multiple fields to traverse multiple levels. Example: {"first_level: {"second_level": 123456}} Result of Traverse "first_level" equals to {"second_level": 123456}

Traverse: allows to traverse the dictionary-like field (such as JSON) given a name. You can specify multiple fields to traverse multiple levels.
Example: `{"first_level: {"second_level": 123456}}`
Result of `Traverse "first_level"` equals to `{"second_level": 123456}`