Remove length check for sk-proj keys #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@transmissions11 would you or another code owner be able to review? Would be greatly appreciated because I think OpenAI changed their key format and this prevents new users from onboarding onto flux. Thank you! 🙏 |
|
@transmissions11 friendly ping if you have a chance to review |
|
Closing from lack of activity. Happy to open again if needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Context: #99
I recently created an OpenAI API key, and it has a length of 164 characters, so the
isValidAPIKeycheck doesn't work correctly.Solution
Since I couldn't quickly find documentation from OpenAI on acceptable lengths of API keys and since OpenAI is free to change the key length whenever they want, I just removed the length check. I kept the length check for
sk-keys since I don't know if those are definitely restricted to a certain length.Checklist