Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Postgres Range Types #1487

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sirwolfgang
Copy link

@sirwolfgang sirwolfgang commented Aug 18, 2024

This Add/Fixes support for Postgres Range types: #1486

Todos:

  • Wrote good commit messages.
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new
    code introduces user-observable changes.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.

@sirwolfgang
Copy link
Author

sirwolfgang commented Aug 19, 2024

I'm unable to get specs to run locally:

bundler: failed to load command: appraisal (/Users/zane/.gem/ruby/3.3.0/bin/appraisal)
/Users/.../.gem/ruby/3.3.0/gems/appraisal-2.4.1/lib/appraisal/appraisal.rb:102:in `read': No such file or directory @ rb_sysopen - /Users/.../Documents/Projects/quiltt/paper_trail/gemfiles/rails_6.1.gemfile.lock (Errno::ENOENT)

And not sure what to do about the coverage issue with new Postgres code pulling down the report for SQlite.

So these specs are mostly a guess.

@sirwolfgang sirwolfgang marked this pull request as ready for review August 19, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant