Rails 7.2 compatibility #1477
Rails 7.2 compatibility #1477
Conversation
|
Can you please squash your commits into 1? You also need to update this line - That CI failure regarding coverage - these coverage metrics are pretty pointless imo, I would prefer to just remove it from the project. |
theodorton
force-pushed
the
rails-7-2
branch
2 times, most recently
from
5ffca52
to
5a62060
Compare
|
I've fixed the compatibility spec, added the new appraisal to the CI matrix and squashed. |
theodorton
force-pushed
the
rails-7-2
branch
2 times, most recently
from
baedbf3
to
844dce1
Compare
|
any update on this please? |
|
Updated appraisal to use the official Rails 7.2 release. I can't do much about the coverage metrics that @fatkodima already mentioned. @jaredbeck Is there any more work needed from my side to get this to a mergeable state? |
|
Hi paper trail gem folks 👋🏻 i'm adding my voice to the chorus of encouragement to merging this PR or the other one #1485 |
|
Likewise, hello people from paper trail gem, I also add my voice and encouragement to merge this PR 🫶 |
| @@ -59,11 +59,14 @@ jobs: | |||
| # have set this up with each database as a separate job, but then we'd be | |||
| # duplicating the matrix configuration three times. | |||
| matrix: | |||
| gemfile: [ 'rails_6.1', 'rails_7.0', 'rails_7.1' ] | |||
| gemfile: [ 'rails_6.1', 'rails_7.0', 'rails_7.1', 'rails_7.2' ] | |||
|
|
|||
| # To keep matrix size down, only test highest and lowest rubies. | |||
| # See "Lowest supported ruby version" in CONTRIBUTING.md | |||
| ruby: [ '3.0', '3.2' ] | |||
There was a problem hiding this comment.
should this be updated?
ruby : [ '3.1', '3.3']see https://endoflife.date/ruby
per https://github.com/paper-trail-gem/paper_trail/blob/master/.github/CONTRIBUTING.md#lowest-supported-ruby-version
|
Let's focus on #1485 . I will close this P.R. @theodorton could you please check if you could improve #1485 ? |
master(if not - rebase it).code introduces user-observable changes. - Not relevant; refactoring to support Rails 7.2
and description in grammatically correct, complete sentences.