make a new llvm package (v6.0.0) (now with lld!) #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pantsbuild/pants#5663, I talk about adding
lld
to the llvm tools we already provide. We were actually already doing this on osx because LLVM provides a binary package for osx includeclang
,lld
, and a few other goodies, but for linux you have to individually check out a subdirectory in svn or download a separate tarball. We continue to download tarballs to build an LLVM release from source on linux, so this pr adds thelld
source tarball and configures the build to enable building and installinglld
. There is no functional change to the binary for osx -- thebuild-clang.sh
script was renamed tobuild-llvm.sh
and a few minor edits were made to the script.For context on LLVM releases and building them from source in Linux, see the LLVM Download Page and Building LLVM with CMake.
I will be making a pants pr in a bit which shows how this would be consumed: the
Clang
BinaryTool will be removed in favor of anLLVM
BinaryTool because this package no longer provides just clang. You can hold off on review for now if you want until that pr goes through review. The scripts worked for me on the first try on my linux and osx machines -- my attempt using thepantsbuild/centos6:latest
docker container did run out of virtual memory, but I don't think that's going to be due to the build because it's worked on other linux environments and there would likely be some setting I could change to fix that.