Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update README.md #35

wants to merge 2 commits into from

Conversation

patilmsangram
Copy link

Project name:

Project website/repository:

License:

Checklist for new projects:

  • The project is open-source and accessible.
  • Searched the existing entries to make sure this is not a duplicate.
  • Contains only a single addition (make separate PRs if adding more than one).
  • Added the link to the bottom of the relevant category.
  • Add icon from the media/icon/ folder if applicable (like ![Python](media/icon/python.png) ).
  • Created a new category only if necessary.
  • Checked spelling and grammar.
  • Removed trailing whitespace and periods.
  • Confirm the dash – is not a minus -.
  • Used title-casing (AP style) for project name.

jhamman
jhamman requested changes Oct 29, 2019
View reviewed changes
Copy link
Member

@jhamman jhamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. A few comments below before merging. Also, please complete the checklist above.

README.md Outdated
@@ -105,6 +105,7 @@ While packages are not technically specific to AOCH science, they are so essenti
| --- |

- [OGGM](https://oggm.org/) - ![Python](media/icon/python.png) Open Global Glacier Model
- [TopoToolbox](http://topotoolbox.wordpress.com/)-Matlab-based software for topografical analysis
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space around the dash, matlab logo, and this may be misplaced (not sure it belongs in the Glaciology section)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamman jhamman jhamman requested changes

Assignees
No one assigned
Labels
awaiting response
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patilmsangram @jhamman