Limit texture size #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SwissalpS
commented
Nov 28, 2024
•
SwissalpS
commented
- fixes metadata can get too big for server to handle #5
- some other hidden issues.
- cleans up code-style
- adds luacheck
- minimizes metadata size
- keeps history per player for next flag
- updates mask buttons according to selected colour (players were confused whether it was the black part or the white part that was going to be coloured)
- use same whitespace style throughout and fix some indents. - change from minetest. to core. namespace.
- unused arguments - shaddowed vars - var redeclarations - some whitespace involved in above lines
save some lines and some extra method calls.
tabs -> spaces
...that slipped through the cracks on previous whitespace edit
or use the faster repeat-until-loop
fixes #5 transformation history was shared by all users and kept growing as it was never truely reset. Every time a user used a banner a white background was dumped on top of the stack making it possible to crash the server through an overflow to core.serialize() function.
also changed banners.max_transformations to banners.max_undo_levels and lowered the value substantially.
since it isn't updating everything, only the preview and the inventory item
to reflect the currently selected colour.
|
I suggest squashing this merge ;) |
BuckarooBanzay
approved these changes
Nov 28, 2024
|
Not quite. The 256 limit is for the undo-history, which is in RAM and now per player. The metadata stored in the item used to have the undo history of all players in it for no reason. Now the string generator works from the top of the stack downward and stops the first time it finds a background. It also skips any duplicate masks that make no difference in the resulting image. |
|
max metadata size is now: x = #masks
y = #longest_mask_name
z = #longest_colour_name
max_size = x * (y + z)Of course the exact max_size is what comes out of The undo-limit now opens an easter egg where players can make flags without a background. For that they have to add 256 masks that are not background so that the original background is dropped off the stack. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.