-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement PostgreSQL sessions #231
base: main
Are you sure you want to change the base?
Conversation
What are you thoughts on using SESSION_POSTGRESQL = ThreadedConnectionPool(...) rather that using SESSION_POSTGRESQL_MAX_DB_CONN and uri? This would be more similar to most of the other backends (SQLALchemy is a bit different)? |
Yeah, makes sense, will implement it like this. I just don't think it should be optional as there is no way to guess the URI of the database (even if we assume the db is on localhost, you still need to specify the db name). |
Awesome! For some reason the multiple python version test strategy isn't working, because some of those optional parameter type hints should fail for 3.8. Everything else looking good to me |
Should be fixed now 👍🏽 |
Has been merged into dev |
Integrating
flask-pg-session
intoflask-session
.To do: