Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement PostgreSQL sessions #231

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

Conversation

giuppep
Copy link
Contributor

@giuppep giuppep commented Mar 28, 2024

Integrating flask-pg-session into flask-session.

To do:

  • tests
  • documentation

@Lxstr
Copy link
Contributor

Lxstr commented Mar 29, 2024

What are you thoughts on using SESSION_POSTGRESQL = ThreadedConnectionPool(...) rather that using SESSION_POSTGRESQL_MAX_DB_CONN and uri? This would be more similar to most of the other backends (SQLALchemy is a bit different)?

@giuppep
Copy link
Contributor Author

giuppep commented Apr 3, 2024

What are you thoughts on using SESSION_POSTGRESQL = ThreadedConnectionPool(...) rather that using SESSION_POSTGRESQL_MAX_DB_CONN and uri? This would be more similar to most of the other backends (SQLALchemy is a bit different)?

Yeah, makes sense, will implement it like this. I just don't think it should be optional as there is no way to guess the URI of the database (even if we assume the db is on localhost, you still need to specify the db name).

@giuppep giuppep marked this pull request as ready for review April 3, 2024 19:41
@Lxstr
Copy link
Contributor

Lxstr commented Apr 9, 2024

Awesome! For some reason the multiple python version test strategy isn't working, because some of those optional parameter type hints should fail for 3.8. Everything else looking good to me

@giuppep
Copy link
Contributor Author

giuppep commented Apr 16, 2024

Awesome! For some reason the multiple python version test strategy isn't working, because some of those optional parameter type hints should fail for 3.8. Everything else looking good to me

Should be fixed now 👍🏽

@Lxstr
Copy link
Contributor

Lxstr commented Apr 18, 2024

Has been merged into dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants