Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ovpn user call and mgmt fixes + added new flag for init users db #296

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

matveyI
Copy link

@matveyI matveyI commented Jan 6, 2025

Hello everyone!

I suggest several fixes:

  1. Added formatting for defining api endpoints + changed the order of importing libraries;
  2. Fixed typos in the --db.path key when calling the openvpn-user command;
  3. Added a new parameter authDataBaseInit for initializing the openvpn user database;
  4. Added the DB initialization function (item 3) and its call when initializing the ovpn-admin server if the auth.db-init flag is true;
  5. Changed the "status" command to "status 1" for the mgmt interface of the openvpn server for correct parsing of the status of active clients and routes in alpine and ubuntu / debian. In ubuntu, the output of "status" was different from the output in alpine. However, "status 1" solves the problem;
  6. Added the "openvpn-user db-migrate" command for database migration in the "configure.sh" script. Its absence may lead to errors when adding a new user, since the users table lacked certain columns described in the INSERT sql query.

I'll note 3 and 4 separately. I believe that the "auth.db-init" flag is necessary, since using configure.sh is not always possible (for example, there is no script in the package, only a binary, or easy-rsa / firewall / openvpn server have already been configured differently).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant