Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor local registry and dynamically fetching stack images #86

Merged

Conversation

pacostas
Copy link
Contributor

Summary

This PR:

  • transfers the functionality of spawning a new local registry with crane from jammy-tiny-stack in to tools.sh. The registry functionality has been transferred to a common place (tools.sh) as it will also be used in the future on the receipts in combination with multiacrch as is implemented at the moment on jammy-tiny-stack
  • dynamically iterate over the stacks on the integration tests by fetching them from the images.json. Removing that way the hard coded versions of stacks.
  • Same code works with jammy-base-stack.

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pacostas pacostas requested a review from a team as a code owner June 21, 2024 17:16
@pacostas pacostas force-pushed the local-registry-implemntation branch from b7eeddc to 9a6bb22 Compare June 21, 2024 17:43
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit cfd06a7 into paketo-community:main Jun 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants