Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump more versions #775

Merged
merged 9 commits into from
Jul 31, 2024
Merged

Bump more versions #775

merged 9 commits into from
Jul 31, 2024

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented Jul 23, 2024

Summary

Bump project versions.

@dmikusa
Bump more versions
bc54769 
Signed-off-by: Daniel Mikusa <[email protected]>
@dmikusa dmikusa requested a review from a team as a code owner July 23, 2024 15:19
@anthonydahanne
Copy link
Member

kotlin broken with modern spring?
@dmikusa

anthonydahanne
anthonydahanne requested changes Jul 24, 2024
View reviewed changes
Copy link
Member

@anthonydahanne anthonydahanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kotlin tests break

dmikusa added 4 commits July 25, 2024 09:18
@dmikusa
Update kotlin project
43283f0 
Signed-off-by: Daniel Mikusa <[email protected]>
@dmikusa
Update JAR example
a440aef 
Signed-off-by: Daniel Mikusa <[email protected]>
@dmikusa
Update READMEs
147082b 
Signed-off-by: Daniel Mikusa <[email protected]>
@dmikusa
Switch to java 17,21 for Kotlin sample
c3a7e2e 
Signed-off-by: Daniel Mikusa <[email protected]>
@dmikusa dmikusa requested a review from a team as a code owner July 25, 2024 13:32
@ForestEckhardt
Copy link
Contributor

@dmikusa I am still seeing Java test failures

@dmikusa
Copy link
Contributor Author

dmikusa commented Jul 29, 2024

@ForestEckhardt Yes, sorry. The WAR failure is giving us fits. Still trying to figure out what changes/broke there. Hope to have it sorted out soon.

@ForestEckhardt
Copy link
Contributor

@ForestEckhardt Yes, sorry. The WAR failure is giving us fits. Still trying to figure out what changes/broke there. Hope to have it sorted out soon.

Gotcha thanks for looking into it!

@dmikusa
Copy link
Contributor Author

dmikusa commented Jul 30, 2024

Woohoo, tests are passing!

anthonydahanne
anthonydahanne approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@anthonydahanne anthonydahanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a huge amount of binary files in this PR....
I understand it's because the sample purpose is to test the buildpack against a pre compiled app.

Somehow, couldn't we have a step for this sample to setup-java and run mvnw ?

I understand it's a sample app, nothing risky, and I don't want to delay this great upgrade further.

Let's keep in mind for later!
Thanks!

@dmikusa dmikusa merged commit 40432aa into main Jul 31, 2024
15 checks passed
@dmikusa dmikusa deleted the workflows branch July 31, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonydahanne anthonydahanne anthonydahanne approved these changes

@ForestEckhardt ForestEckhardt Awaiting requested review from ForestEckhardt ForestEckhardt is a code owner automatically assigned from paketo-buildpacks/content-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmikusa @anthonydahanne @ForestEckhardt