Add pagination handling for find-asset action #767
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The action
actions/release/find-asset/entrypoint
retrieves all the releases with the GitHub API but it does not take into account cases in which pagination is activated (number of releases greater than 100) and therefore generates errors when obtaining them.For the specific case of Jammy Full Stack, there are 101 releases in total, so the result of the command is something like this:
Note that the results are 2 sets of JSON arrays. With the proposed change, It will merge the JSON arrays from the GitHub API response using
jq
into a single JSON.Fix paketo-buildpacks/jammy-full-stack#14
Checklist