Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix matcher handling Play 2.9.x backport #729

Merged

Conversation

reardonj
Copy link
Contributor

@reardonj reardonj commented Dec 3, 2024

Backport of fix in #728 for Play 2.9

  • Precompile regex
  • coalesce adjacent rules so that matchers behave properly

- Precompile regex
- coalesce adjacent rules so that matchers behave properly
@reardonj reardonj changed the title Fix matcher handling Fix matcher handling Play 2.9.x backport Dec 3, 2024
@leleuj
Copy link
Member

leleuj commented Dec 3, 2024

Thanks. Can you take a look at the build failure?

@reardonj
Copy link
Contributor Author

reardonj commented Dec 3, 2024

Alright; got it to build locally!

@leleuj leleuj merged commit 516ccc9 into pac4j:12.0.x-PLAY2.9 Dec 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants