Make a Merge() call allow not-yet-recognized new fields in P4Info files #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is helpful when p4c adds new P4Info fields to the P4Info files it generates, but the consumers have not yet all been updated to recognize them. The most recent example of this in 2024-Aug is the initial_default_action field of Table messages. Signed-off-by: Andy Fingerhut <[email protected]>
Signed-off-by: Andy Fingerhut <[email protected]>
fruffy
approved these changes
Sep 1, 2024
antoninbas
approved these changes
Sep 3, 2024
antoninbas
deleted the
make-code-more-permissive-for-extra-fields-in-p4info-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is helpful when p4c adds new P4Info fields to the P4Info files it generates, but the consumers have not yet all been updated to recognize them. The most recent example of this in 2024-Aug is the initial_default_action field of Table messages.