Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround unexpected compilation bug #108

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Conversation

Hoooao
Copy link
Contributor

@Hoooao Hoooao commented Aug 8, 2023

I am working on a CI pipeline for p4c-dpdk and dpdk swx here. I found an unexpected problem that happens by chance. It is a compilation problem, which seems have already been discovered before yet not fully fixed. I workaround it with the same approach as the previously discovered one.

Here is the log showing the .o file was not generated while it was actually generated:

...
2023-08-08 11:32:15.539210 INFO  BF_PORT Exit port_mgr_config_import
2023-08-08 11:32:15.664004 ERROR BF_PIPE STATUS: -1
2023-08-08 11:32:15.664158 ERROR BF_PIPE dal_enable_pipeline line:122  Cannot generate /tmp/p4.o file  

2023-08-08 11:32:15.664187 ERROR BF_PIPE Failed to Build Pipeline pipe
2023-08-08 11:32:15.664210 ERROR BF_DVM Device add handling failed for dev 0, sts Internal error (22), Client pipe-mgr 
2023-08-08 11:32:15.664228 ERROR BF_DVM Device add failed for dev 0, sts Internal error (22)
2023-08-08 11:32:15.664286 INFO  BF_PORT Entering port_mgr_dev_remove
2023-08-08 11:32:15.664321 INFO  BF_PAL STUB fixed_function_dev_remove
2023-08-08 11:32:15.664335 INFO  BF_LLD Entering dummy STUB:lld_dev_remove
...

@Hoooao
Copy link
Contributor Author

Hoooao commented Aug 8, 2023

@swaroopsarma @jamescchoi @riyazahm22 @vsureshkumarp Can you review this?

Changed Log

Added errno info
Copy link

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jafingerhut
Copy link

I approved this, maybe not as a final state we want the code to be in to solve this issue cleanly, but as a workaround that allows us to make progress.

Note: I am not a maintainer on this project, so my approval does not allow this PR to be merged. You will need to ask a project maintainer to review and approve before that can happen.

Copy link
Collaborator

@swaroopsarma swaroopsarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
we need to look at the failure and try to find a solution ultimately

@jafingerhut
Copy link

If someone with permission could merge this, that would be great. @swaroopsarma Perhaps you do?

@swaroopsarma swaroopsarma merged commit ea8ed80 into p4lang:main Aug 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants