resolve bug with empty strings and enhance the sent email's body #98
Conversation
| bodyAttr.put("magicLink", link); | ||
| emailTemplateProvider | ||
| .setRealm(realm) | ||
| .setUser(user) | ||
| .setAttribute("realmName", realmName) |
There was a problem hiding this comment.
I'm not sure about this deletion, but according to my quick review noone uses this.
There was a problem hiding this comment.
I believe it is still used in the customizations. Could you please also check the https://github.com/p2-inc/keycloak-themes/blob/main/src/main/resources/theme/mustache/email/html/magic-link-continuation-email.mustache#L3
| @@ -1,4 +1,4 @@ | |||
| <#import "template.ftl" as layout> | |||
| <@layout.emailLayout> | |||
| ${kcSanitize(msg("magicLinkContinuationBodyHtml", realmName, magicLink))?no_esc} | |||
There was a problem hiding this comment.
Please also create a separate PR for updating this on the customizations repository https://github.com/p2-inc/keycloak-themes/tree/main/src/main/resources/theme/mustache/email/html
| bodyAttr.put("magicLink", link); | ||
| emailTemplateProvider | ||
| .setRealm(realm) | ||
| .setUser(user) | ||
| .setAttribute("realmName", realmName) |
There was a problem hiding this comment.
I believe it is still used in the customizations. Could you please also check the https://github.com/p2-inc/keycloak-themes/blob/main/src/main/resources/theme/mustache/email/html/magic-link-continuation-email.mustache#L3
Closes #97