Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed/btn on hover #178

Merged
merged 2 commits into from
Oct 7, 2023
Merged

Conversation

Neeraaaj
Copy link

@Neeraaaj Neeraaaj commented Oct 7, 2023

fixed the issue of hovering the btn from light to dark

dark mode

dark

white mode
white

@vercel
Copy link

vercel bot commented Oct 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
devprofiles ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2023 1:39pm

@netlify
Copy link

netlify bot commented Oct 7, 2023

Deploy Preview for snazzy-wisp-6cc02d ready!

Name Link
🔨 Latest commit 5ee3f55
🔍 Latest deploy log https://app.netlify.com/sites/snazzy-wisp-6cc02d/deploys/65215f9a580996000853a115
😎 Deploy Preview https://deploy-preview-178--snazzy-wisp-6cc02d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the waiting for reviewers Soon a maintainer will review label Oct 7, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Neeraaaj! Thanks for creating the pull request!

Soon the maintainers/owner will review it and provide you with feedback/suggestions, Make sure to star this awesome repository

@oyepriyansh
Copy link
Owner

on hover the light theme button is shown

image

@Neeraaaj
Copy link
Author

Neeraaaj commented Oct 7, 2023

@oyepriyansh yes i thought the themes of button should be contradictory like in dark mode the button should be light on hover and vise versa with the light theme

@Neeraaaj
Copy link
Author

Neeraaaj commented Oct 7, 2023

@oyepriyansh should i keep the same and just fix the text issue?

@oyepriyansh
Copy link
Owner

just fix the text issue

@oyepriyansh oyepriyansh merged commit 5ee3f55 into oyepriyansh:master Oct 7, 2023
7 checks passed
@oyepriyansh oyepriyansh removed the waiting for reviewers Soon a maintainer will review label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants