-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ (stacked area) improve hover states / TAS-687 #4129
base: master
Are you sure you want to change the base?
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sophiamersmann and the rest of your teammates on Graphite |
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 1346 (851c10) ❌ Edited: 2024-11-11 09:34:26 UTC |
1a672b3
to
5b0cb32
Compare
92e6f1a
to
736e5f6
Compare
Stacked area charts are in a hover state when…
This PR cleans up the code around that and ensures that the hover state of a stacked area chart looks consistent, regardless of how it has been triggered.
In general, we want to move to a world where hovering highlights the hovered elements while muting all other elements by reducing their opacity (as opposed to greying them out).
This PR focuses on the stacked area chart, but the hover state of the line chart has also been updated to match the behaviour of the line legend.
Examples: