Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/version 3 #1033

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

Feature/version 3 #1033

wants to merge 34 commits into from

Conversation

owen2345
Copy link
Owner

@owen2345 owen2345 commented Jan 8, 2023 •
edited by texpert
Loading

  • Configure docker for local setup
  • Use some getting-started documentation as the default content
  • Improve performance
    • Refactor custom fields/custom field group
  • Refactor/improve web documentation
  • Improve admin UI for easier and more intuitive usage
  • Improve and add missing tests (unit and end-to-end)
  • Improve code quality and code style
    • Frontend
    • Backend
  • Add shell service to generate the entire app (rails + camaleon + docker settings)
  • Reduce third-party gem dependencies
  • Upgrade tinymce 4 to 5 and 5 to 6 (Optional)
  • Refactor or replace features
    - [ ] New uploader
    - [ ] New built-in theme that uses the same frontend stack as the admin theme so we don't have any additional dependencies.

Some discussions here: #1027
Please do not hesitate to add/edit/remove topics from the list

@owen2345 owen2345 mentioned this pull request Jan 8, 2023
Merged
texpert
texpert approved these changes Jan 8, 2023
View reviewed changes
Copy link
Collaborator

@texpert texpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with the suggestion to craft a 2.7.0 release from the current master. and then merge this and all other PRs prepairing to v3

Also, I think it would be better, for clarity, to have the topics in the description of this PR as some issues with a v3 milestone, each of them being addressed in a separate PR

brian-kephart
brian-kephart approved these changes Jan 12, 2023
View reviewed changes
Copy link
Collaborator

@brian-kephart brian-kephart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for kicking this off @owen2345!

  • Improve code quality and code style

@texpert has been working on using ESlint. Should we use RuboCop or StandardRB for the Ruby code as well?

  • Reduce third-party gem dependencies

will-paginate-bootstrap, jquery-rails, sass-rails, maybe draper? Any others?

  • Upgrade tinymce 4 to 5 and 5 to 6 (Optional)

I submitted a PR for this a long time ago that wasn't merged due to being a potentially breaking change. I'll have to see if I can dig it up. It required some changes, but worked well.

Things to add:

  • New uploader
  • New built-in theme that uses the same frontend stack as the admin theme so we don't have any additional dependencies.

@owen2345
Copy link
Owner Author

Just as a note: This branch could act as a v3 version and move the current master branch into v2 (once v3 is released) which in the future we can continue doing basic support, like security issues.

@owen2345
Copy link
Owner Author

owen2345 commented Jan 12, 2023 •
edited
Loading

Thanks for kicking this off @owen2345!

  • Improve code quality and code style

@texpert has been working on using ESlint. Should we use RuboCop or StandardRB for the Ruby code as well?

  • Reduce third-party gem dependencies

will-paginate-bootstrap, jquery-rails, sass-rails, maybe draper? Any others?

  • Upgrade tinymce 4 to 5 and 5 to 6 (Optional)

I submitted a PR for this a long time ago that wasn't merged due to being a potentially breaking change. I'll have to see if I can dig it up. It required some changes, but worked well.

Things to add:

  • New uploader
  • New built-in theme that uses the same frontend stack as the admin theme so we don't have any additional dependencies.

@brian-kephart this version v3 is indeed the release where we can include all the breakable changes with quality, security, performance, and usability in mind (lets try to include a way to migrate from v2 into v3 or add a script or library to help with the migration or try to add the backward compatibility)

  • Regarding code style, I vote for rubocop, what about you @texpert @brian-kephart ?
  • Regarding new things, updated in the PR list

@texpert
Copy link
Collaborator

texpert commented Jan 12, 2023

+1 for rubocop

@brian-kephart brian-kephart added this to the Version 3 milestone Feb 7, 2023
owen2345 and others added 18 commits January 18, 2024 01:11
@owen2345 @texpert
feat: configure docker for testing the gem
b69074a
@owen2345 @texpert
feat: update test settings to run test
21c10d3
@owen2345 @texpert
fix: update default test command
9f53a37
@texpert
Add ESLint to the CI
af34a75
@texpert
Ignore the magnific and modernizr packages in any location (in dummy …
1fda1a3 
…app as well)
@texpert
Fix dummy app ESLint issues
3c53fb4
@texpert
Specify some globals for ESLint and fix ESLint issues in the `uploade…
363fca7 
…r` JS files
@texpert
Fix ESLint issues in the admin/_user_profile.js and `admin/_custom_…
e0e96fb 
…fields_form.js`
@texpert
Fix ESLint issues in the admin/_translator.js
c9c1a2f
@texpert
Fix ESLint issues in the admin/_post.js
effd0a3
@texpert
Fix ESLint issues in the admin/_modal.js
58ac873
@texpert
Fix ESLint issues in the admin/_libraries.js
7012a28
@texpert
Fix ESLint issues in the admin/_i18n.js
64d700e
@texpert
Fix ESLint issues in the admin/_data.js
8ff615d
@texpert
Fix ESLint issues in the admin/_custom_fields.js
a54566b
@texpert
Fix ESLint issues in the admin/_actions.js
65f39cc
@texpert
Fix ESLint issues in the themes/camaleon_first/assets/js/hover.zoom.js
0a9afd1
@texpert
Fix ESLint issues in the themes/camaleon_first/assets/js/main-ver.js
dacb5b4
texpert and others added 16 commits January 18, 2024 01:11
@texpert
Fix ESLint issues in the plugins/visibility_post/assets/js/form.js
d5f6d7b
@texpert
Fix initProfileForm function name to InitProfileForm
87cf081
@dependabot @texpert
Bump json5 from 1.0.1 to 1.0.2
2479e68 
Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@brian-kephart @texpert
Allow latest TinyMCE
11b5af0
@brian-kephart @texpert
compile TinyMCE assets
7acc7eb
@brian-kephart @texpert
More TinyMCE 5 migration changes
303f06e
@brian-kephart @texpert
Run ESLint
9d680fc
@brian-kephart @texpert
Fix mistranslated for/in loops
04ba1b8
@brian-kephart @texpert
Update CHANGELOG [skip ci]
2176ddd
@brian-kephart @texpert
Replace sass-rails with dartsass-sprockets
4965ed9
@brian-kephart @texpert
Remove sassc from Gemfile
12248b1
@texpert
Post-rebase fix: Remove duplicated require 'capybara/rspec'
0a14b2d
@texpert
Revert renaming to camelCase functions used in ERB - doesn't work
db3c32c
@texpert
Revert a few renaming to camelCase functions used in ERB - doesn't work
8910501
@texpert
After-rebase fix for the CHANGELOG.md
d756b6e
@texpert
Revert Capybara.javascript_driver settings to `:selenium_chrome_headl…
fe61e0f 
…ess` to avoid capybara-screenshot errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-kephart brian-kephart brian-kephart approved these changes

@texpert texpert texpert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 3
Development

Successfully merging this pull request may close these issues.
3 participants
@owen2345 @texpert @brian-kephart