Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(file): display error message for multiple files #857

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JacquesLarique
Copy link
Contributor

Title of the Pull Requests

Fix File component extension error display

Description of the Change

Removed condition to display errors

Benefits

Better user experience by adding information regarding the invalid extension error for a file

Possible Drawbacks

Applicable Issues

When a user select a file with an invalid extension, the file appear in error but without any explanation as to why the file is invalid.

MaximeBajeux
MaximeBajeux previously approved these changes Sep 3, 2024
oalkabouss
oalkabouss previously approved these changes Sep 3, 2024
Copy link
Contributor

@anooparveti anooparveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit of the title can be display error message for multiple files

@JacquesLarique JacquesLarique changed the title fix(file): fixed issue where error was not displayed for multiple fix(file): display error message for multiple files Sep 4, 2024
@JacquesLarique
Copy link
Contributor Author

JacquesLarique commented Sep 6, 2024

This fix is not correct I need to redo it

This comment is no longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants