Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pci-load-balancer): review design #14125

Open
wants to merge 1 commit into
base: feat/pci-load-balancer
Choose a base branch
from
Open

feat(pci-load-balancer): review design #14125

wants to merge 1 commit into from

Conversation

kqesar
Copy link
Contributor

@kqesar kqesar commented Nov 15, 2024

ref: DTCORE-2846

Question Answer
Branch? feat/pci-load-balancer
Bug fix? yes/no
New feature? yes/no
Breaking change? yes/no
Tickets DTCORE-2846
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@kqesar kqesar requested review from a team as code owners November 15, 2024 13:55
@kqesar kqesar requested review from frenautvh and seven-amid and removed request for a team November 15, 2024 13:55
@github-actions github-actions bot added the feature New feature label Nov 15, 2024
@kqesar
feat(pci-load-balancer): review design
f13210c 
ref: DTCORE-2846
Signed-off-by: Yoann Fievez <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
16.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenautvh frenautvh frenautvh approved these changes

@sidlynx sidlynx sidlynx approved these changes

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kqesar @sidlynx @frenautvh