Adds RELEASING.md #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oldergod
commented
Dec 14, 2023
Comment on lines
+36
to
+53
| 4. Tag the release and push to GitHub. | ||
|
|
||
| ``` | ||
| git commit -am "Prepare for release $RELEASE_VERSION." | ||
| git tag -a $RELEASE_VERSION -m "Version $RELEASE_VERSION" | ||
| git push && git push --tags | ||
| ``` | ||
|
|
||
| 5. Wait for [GitHub Actions][github_actions] to start building the release. | ||
|
|
||
| 6. Prepare for ongoing development and push to GitHub. | ||
|
|
||
| ``` | ||
| sed -i "" \ | ||
| "s/VERSION_NAME=.*/VERSION_NAME=$NEXT_VERSION/g" \ | ||
| `find . -name "gradle.properties"` | ||
| git commit -am "Prepare next development version." | ||
| git push | ||
| ``` | ||
|
|
||
| 7. CI will release the artifact and publish the documentation. |
There was a problem hiding this comment.
@kdubb can you confirm if that's correct?
Specially, will it be auto-released on sonatype or does one have to log on sonatype and release the artifacts?
There's some config in the root build.gradle.kts but I don't know for instance what githubRelease does.
There was a problem hiding this comment.
we'll give it a try and see how it goes!
There was a problem hiding this comment.
Yes this looks correct. Note that the release workflow is keyed to the following regex:
on:
push:
tags: [ "[0-9]+.[0-9]+.[0-9]+**" ]
dnkoutso
reviewed
Dec 14, 2023
oldergod
force-pushed
the
bquenaudon.2023-12-14.releasingdoc
branch
from
05151ce
to
a9808b7
Compare
oldergod
force-pushed
the
bquenaudon.2023-12-14.releasingdoc
branch
from
a9808b7
to
b9d6a35
Compare
kdubb
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.