Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-5792 Add missing class to additional tag groups in Tag Sets to fix skins #4960

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

slavalamp
Copy link

@slavalamp slavalamp commented Nov 14, 2024

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-5792

The issue only mentions Reversi but Happy 17th! and Low Vision Default also have the wrong border color there.

Purpose

Adds a missing "group" class to additional tag groups in Tag Sets so that they're targeted by Reversi, Happy 17th! and Low Vision Default site skins correctly.

This does not affect the default skin or most other public skins. Out of the three that are affected: Fixie (911) seems to get fixed by this as well, The Hustings (889) also becomes consistent (can't say "fixed" because the contrast there is terrible), and Panda Madness (890) doesn't account for these tag groups and has them look a bit out of place either way.

Testing Instructions

  1. Create a tag set with 31+ Additional tags (the number in the Jira issue is incorrect)
  2. Switch skin to Reversi, or use ?site_skin=929 switch
  3. The tag group headers in the Additional tags section should have dark backgrounds

References

n/a

Credit

slavalamp (they/them)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant