Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-4283 make HTML and classes on the Marked for Later module consistent #4958

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

slavalamp
Copy link

@slavalamp slavalamp commented Nov 12, 2024

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-4283

Purpose

Makes HTML tag and classes of the Marked for Later module on the homepage consistent with the ones on the History and Marked for Later pages

Testing Instructions

  1. Have a work marked for later
  2. Create and use a site skin that attempts to target history blurbs, e.g.: ol.reading .blurb { background: pink; }
  3. The Marked for Later blurbs on the homepage should have pink backgrounds

References

n/a

Credit

slavalamp (they/them)

same name on Jira

@slavalamp slavalamp force-pushed the AO3-4283_marked_for_later_html_consistency branch from 7462530 to 5d9114e Compare November 12, 2024 23:16
Copy link
Collaborator

@sarken sarken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, slavalamp!

Thank you so much for this pull request. It looks good to me, so I've marked it approved!

I've also given your account permission to comment on, assign, and transition issues in the future. I've also assigned the relevant Jira issue to you and set its status to In Review, so no need to do that.

Thanks again for contributing! If you have any questions, you can contact us at [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants